Skip to content

chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-01)#3079

Open
svcnvidia-nemo-ci wants to merge 1 commit intor0.4.0from
bump-ci-container-2026-04-01-r0.4.0-core_r0.17.0
Open

chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-01)#3079
svcnvidia-nemo-ci wants to merge 1 commit intor0.4.0from
bump-ci-container-2026-04-01-r0.4.0-core_r0.17.0

Conversation

@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Apr 1, 2026

🚀 PR to bump uv.lock in r0.4.0.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated third-party dependencies to latest versions.

…-04-01)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor Author

/ok to test 3fb0863

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 1, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

📝 Walkthrough

Walkthrough

Updated the 3rdparty/Megatron-LM submodule pointer to reference a new upstream commit. This is a routine submodule version bump that advances the pinned commit hash without introducing any local code modifications.

Changes

Cohort / File(s) Summary
Submodule Update
3rdparty/Megatron-LM
Updated submodule commit pointer from 3758b54b2bd9d00f0adbe8bf343a0e6bbcd75d1d to a3a7a0c699876bb6699f47581c3ca6da764abf9d.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • yaoyu-33
  • ko3n1g
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions bumping 'uv.lock' but the actual changes are to the Megatron-LM submodule commit pointer. The title is misleading as it doesn't reflect the main change in the changeset. Update the title to accurately reflect that the Megatron-LM submodule was bumped to a new commit, or clarify what 'uv.lock' changes are included in this PR.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor routine maintenance changes: lockfile bump and submodule pointer update. No major features, breaking changes, or significant refactoring present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-04-01-r0.4.0-core_r0.17.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The submodule gitlink SHA (a3a7a0c699876bb6699f47581c3ca6da764abf9d)
does not match the pinned commits in .main.commit
(3758b54b2bd9d00f0adbe8bf343a0e6bbcd75d1d) and .dev.commit
(c72c4599012297cfbd1d57e006b544478b6bbf78); fix by making them consistent:
either update the repository submodule gitlink to the intended pinned commit SHA
(change the gitlink to 3758b54... or c72c45... as appropriate) or update the
.main.commit/.dev.commit files to match the current gitlink SHA (a3a7a0...),
then commit the change so git submodule update --init and switch_mcore.sh no
longer checkout conflicting commits.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c791d737-bd7a-4b5a-b36b-af5dc9f22e8e

📥 Commits

Reviewing files that changed from the base of the PR and between 49faf1c and 3fb0863.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • 3rdparty/Megatron-LM

@@ -1 +1 @@
Subproject commit 3758b54b2bd9d00f0adbe8bf343a0e6bbcd75d1d
Subproject commit a3a7a0c699876bb6699f47581c3ca6da764abf9d
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Submodule gitlink SHA in current tree =="
git ls-tree HEAD 3rdparty/Megatron-LM

echo
echo "== Pinned commit files (if present) =="
for f in .main.commit .dev.commit; do
  if [ -f "$f" ]; then
    printf "%s: " "$f"
    tr -d '[:space:]' < "$f"
    echo
  else
    echo "$f: <missing>"
  fi
done

echo
echo "== switch_mcore.sh commit-source references =="
rg -n -C2 'read_commit_file|MAIN_COMMIT|DEV_COMMIT|SUBMODULE_PATH|checkout' scripts/switch_mcore.sh

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 2138


Submodule gitlink SHA does not match pinned commit files—update one to align.

The submodule pointer is set to a3a7a0c699876bb6699f47581c3ca6da764abf9d, but .main.commit is pinned to 3758b54b2bd9d00f0adbe8bf343a0e6bbcd75d1d and .dev.commit is pinned to c72c4599012297cfbd1d57e006b544478b6bbf78. When developers clone and run git submodule update --init, they will check out the gitlink SHA, then switch_mcore.sh main or dev will immediately checkout a different commit. Either update the gitlink to match the intended pinned commit, or update the .main.commit / .dev.commit files to match the gitlink SHA.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The submodule gitlink SHA
(a3a7a0c699876bb6699f47581c3ca6da764abf9d) does not match the pinned commits in
.main.commit (3758b54b2bd9d00f0adbe8bf343a0e6bbcd75d1d) and .dev.commit
(c72c4599012297cfbd1d57e006b544478b6bbf78); fix by making them consistent:
either update the repository submodule gitlink to the intended pinned commit SHA
(change the gitlink to 3758b54... or c72c45... as appropriate) or update the
.main.commit/.dev.commit files to match the current gitlink SHA (a3a7a0...),
then commit the change so git submodule update --init and switch_mcore.sh no
longer checkout conflicting commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants