Skip to content

build: Bump TE to 2.14#2980

Merged
ko3n1g merged 2 commits intomainfrom
ko3n1g/build/bump-te-214
Mar 27, 2026
Merged

build: Bump TE to 2.14#2980
ko3n1g merged 2 commits intomainfrom
ko3n1g/build/bump-te-214

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Mar 25, 2026

What does this PR do ?

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Updated transformer-engine dependency to a newer version for improved compatibility and performance.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

📝 Walkthrough

Walkthrough

Updated the transformer-engine dependency pinned Git commit hash in pyproject.toml from 287770466f0f4433052260a765db5ff7b8be1320 to 71bbefbf153418f943640df0f7373625dc93fa46, changing which revision the uv package manager will install.

Changes

Cohort / File(s) Summary
Dependency Version Update
pyproject.toml
Updated transformer-engine Git commit hash in tool.uv.override-dependencies to pin a different source revision.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • chtruong814
  • thomasdhc
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Results For Major Changes ⚠️ Warning PR bumps Transformer Engine to 2.14, a significant dependency update that could affect numerics and convergence, but lacks required test results and validation evidence in the description. Add test results, convergence validation, and performance benchmarks (if applicable) to the PR description demonstrating no regression with the new TE version.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'build: Bump TE to 2.14' directly describes the main change: updating the transformer-engine (TE) dependency from one commit hash to another (with the implied version being 2.14).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ko3n1g/build/bump-te-214

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Dependencies, packaging, images, and environment setup full-test-suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants