fix(mimo): adapt model layer for MCore submodule bump#2978
Merged
aroshanghias-nvd merged 1 commit intoNVIDIA-NeMo:mimo/phase4-training-rebuildfrom Mar 25, 2026
Conversation
2 tasks
yashaswikarnati
force-pushed
the
mimo/phase4-training-rebuild
branch
from
0aea6d8 to
9642406
Compare
yashaswikarnati
force-pushed
the
mimo/phase4-mcore-bump-fixes
branch
from
3228b92 to
a1cca33
Compare
Bump 3rdparty/Megatron-LM to combined MiMo commit (10b3ddd4d) which
includes MimoOptimizer, distributed checkpoint, and bridge 2D tensor fix.
Adapt Bridge to MCore API changes:
- Migrate all "llm" keys to MIMO_LANGUAGE_MODULE_KEY ("language")
- Add create_pg(["tp", "cp", "ep", "pp", "dp"]) for MimoOptimizer
- Add module_output_ndim for correct 2D/3D tensor routing
- Remove language_module_key kwarg (removed from MimoModelConfig)
- Use MIMO_LANGUAGE_MODULE_KEY instead of removed role.language_module_name
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yashaswikarnati
force-pushed
the
mimo/phase4-mcore-bump-fixes
branch
from
a1cca33 to
d60201f
Compare
aroshanghias-nvd
merged commit f845bf5
into
NVIDIA-NeMo:mimo/phase4-training-rebuild
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_pg(["tp", "cp", "ep", "pp", "dp"])for MimoOptimizer'sintra_dist_optprocess group"llm"key to MCoreMIMO_LANGUAGE_MODULE_KEY("language") inmodule_to_grid_mapwhen constructingMimoModelConfiglanguage_module_keykwarg (removed fromMimoModelConfigin MCore)Test plan
🤖 Generated with Claude Code