Skip to content

chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-03-24)#2969

Closed
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-03-24-main-dev
Closed

chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-03-24)#2969
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-03-24-main-dev

Conversation

@svcnvidia-nemo-ci
Copy link
Contributor

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Mar 24, 2026

🚀 PR to bump uv.lock in main.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated an internal dependency to a newer version.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci
Copy link
Contributor Author

/ok to test 9b62ea5

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 24, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026

📝 Walkthrough

Walkthrough

The 3rdparty/Megatron-LM Git submodule pointer was updated from commit 8f7fbe78609de242630ca4808686bd309694dcab to c72c4599012297cfbd1d57e006b544478b6bbf78, which changes the pinned version of the vendored Megatron-LM dependency.

Changes

Cohort / File(s) Summary
Submodule Reference Update
3rdparty/Megatron-LM
Updated Git submodule commit pointer to a new version of Megatron-LM.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • yaoyu-33
  • maanug-nv
🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions bumping uv.lock but the actual change is updating the 3rdparty/Megatron-LM submodule pointer, which is unrelated to lock file updates. Update the title to accurately reflect the main change: 'chore: Bump Megatron-LM submodule' or similar, removing the misleading lock file reference and emoji noise.
Test Results For Major Changes ⚠️ Warning PR with 1,224 files and 300k+ lines modified lacks documented test results, regression verification, and detailed changelog explaining infrastructure changes beyond uv.lock bump. Add comprehensive test results, convergence regression validation, performance metrics, detailed changelog, and Megatron-LM submodule commit verification to PR description.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-03-24-main-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The submodule at 3rdparty/Megatron-LM references a non-existent commit
(c72c4599012297cfbd1d57e006b544478b6bbf78); verify and fix the submodule pointer
by ensuring the commit hash is correct and pushed to the upstream Megatron-LM
repo, or update the submodule reference to a valid commit (edit the gitlink in
the superproject index/.gitmodules and run git add on the submodule, or use git
submodule update --init --remote to point to a valid branch/commit), then commit
the corrected submodule update so CI can successfully checkout Megatron-LM.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0df952cc-09f4-4ec7-aa49-931f3d5cc140

📥 Commits

Reviewing files that changed from the base of the PR and between 8f43506 and 9b62ea5.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • 3rdparty/Megatron-LM

@@ -1 +1 @@
Subproject commit 8f7fbe78609de242630ca4808686bd309694dcab
Subproject commit c72c4599012297cfbd1d57e006b544478b6bbf78
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the new submodule commit and show the commit log between old and new references.

OLD_COMMIT="8f7fbe78609de242630ca4808686bd309694dcab"
NEW_COMMIT="c72c4599012297cfbd1d57e006b544478b6bbf78"

cd 3rdparty/Megatron-LM || exit 1

# Verify the new commit exists
echo "=== Verifying new commit exists ==="
git cat-file -t "$NEW_COMMIT" 2>/dev/null && echo "Commit $NEW_COMMIT exists" || echo "ERROR: Commit $NEW_COMMIT not found"

# Show commits between old and new
echo ""
echo "=== Commits between old and new submodule references ==="
git log --oneline "$OLD_COMMIT".."$NEW_COMMIT" 2>/dev/null | head -30

# Show summary of file changes
echo ""
echo "=== Summary of changed files ==="
git diff --stat "$OLD_COMMIT".."$NEW_COMMIT" 2>/dev/null | tail -20

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 263


The submodule commit reference does not exist and must be verified before merging.

The new commit c72c4599012297cfbd1d57e006b544478b6bbf78 cannot be found in the Megatron-LM repository. Verify that:

  • The commit hash is correct
  • The commit has been pushed to the upstream repository
  • The submodule is correctly configured to reference the intended commit

Attempting to check out this submodule reference will fail without a valid commit hash.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The submodule at 3rdparty/Megatron-LM
references a non-existent commit (c72c4599012297cfbd1d57e006b544478b6bbf78);
verify and fix the submodule pointer by ensuring the commit hash is correct and
pushed to the upstream Megatron-LM repo, or update the submodule reference to a
valid commit (edit the gitlink in the superproject index/.gitmodules and run git
add on the submodule, or use git submodule update --init --remote to point to a
valid branch/commit), then commit the corrected submodule update so CI can
successfully checkout Megatron-LM.

@yaoyu-33
Copy link
Contributor

Closing stale bot PR.

@yaoyu-33 yaoyu-33 closed this Mar 25, 2026
@yaoyu-33 yaoyu-33 deleted the bump-ci-container-2026-03-24-main-dev branch March 25, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants