Skip to content

chore(beep boop 🤖): Bump uv.lock (main, mcore-main) (2026-03-21)#2937

Closed
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-03-21-main-main
Closed

chore(beep boop 🤖): Bump uv.lock (main, mcore-main) (2026-03-21)#2937
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-03-21-main-main

Conversation

@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Mar 21, 2026

🚀 PR to bump uv.lock in main.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated internal dependency references to latest versions.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor Author

/ok to test 3fa99b6

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 21, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 21, 2026

📝 Walkthrough

Walkthrough

The 3rdparty/Megatron-LM submodule pointer is updated from commit 9ed8b0c4ac8e65d80fb35eecb3656c96b30df943 to commit b4e4d9618e8dec4fe72adb231b56c209130df811, with the .main.commit file tracking this version change accordingly.

Changes

Cohort / File(s) Summary
Submodule version bump
.main.commit, 3rdparty/Megatron-LM
Updated Megatron-LM submodule pointer to a new commit hash, reflecting a version bump of the vendored dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • maanug-nv
  • yaoyu-33
  • ananthsub
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions bumping uv.lock, but the actual changes only update commit hashes in .main.commit and 3rdparty/Megatron-LM, with no modifications to uv.lock files. Update the title to accurately reflect the changes, such as 'chore: Update Megatron-LM submodule pointer' or 'chore: Bump submodule commits (2026-03-21)'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor changes (lock file and submodule updates), which are routine maintenance. No new features, breaking changes, or significant refactoring affecting numerics or performance.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-03-21-main-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The submodule 3rdparty/Megatron-LM is pointing to an unreachable
commit b4e4d9618e8dec4fe72adb231b56c209130df811; update the submodule reference
to a reachable commit on the upstream repo (or push the missing commit to
https://github.com/NVIDIA/Megatron-LM.git), then refresh the submodule state: in
your local clone fetch the upstream for the Megatron-LM submodule, check out the
correct commit or branch, run git add 3rdparty/Megatron-LM and commit the
updated gitlink so the repository points to an accessible commit (ensure the
updated commit replaces references to b4e4d9618e8dec4fe72adb231b56c209130df811).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e11b10e7-1ad0-46c0-936d-3991a34db081

📥 Commits

Reviewing files that changed from the base of the PR and between 1cfafb1 and 3fa99b6.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .main.commit
  • 3rdparty/Megatron-LM

@@ -1 +1 @@
Subproject commit 9ed8b0c4ac8e65d80fb35eecb3656c96b30df943
Subproject commit b4e4d9618e8dec4fe72adb231b56c209130df811
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Show commits added/removed in the Megatron-LM submodule update

cd 3rdparty/Megatron-LM

# Show commits being added in this update
echo "=== Commits added in this update ==="
git log --oneline 9ed8b0c4ac8e65d80fb35eecb3656c96b30df943..b4e4d9618e8dec4fe72adb231b56c209130df811

echo ""
echo "=== Summary of changes ==="
git log --stat 9ed8b0c4ac8e65d80fb35eecb3656c96b30df943..b4e4d9618e8dec4fe72adb231b56c209130df811

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 498


🏁 Script executed:

cd 3rdparty/Megatron-LM 2>/dev/null && pwd || echo "Submodule not initialized"

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 110


🏁 Script executed:

# Check the current .gitmodules and submodule configuration
cat .gitmodules 2>/dev/null | grep -A5 "Megatron-LM" || echo "Not found"

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 183


🏁 Script executed:

# Try to get information about the new commit from the main repository context
cd . && git log --format="%H %s" -n 20 -- 3rdparty/Megatron-LM 2>/dev/null | head -5

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 179


🏁 Script executed:

cd 3rdparty/Megatron-LM && git log --oneline -5

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 146


🏁 Script executed:

cd 3rdparty/Megatron-LM && git rev-parse HEAD

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 111


🏁 Script executed:

cd 3rdparty/Megatron-LM && git log --oneline b4e4d9618e8dec4fe72adb231b56c209130df811~5..b4e4d9618e8dec4fe72adb231b56c209130df811 2>/dev/null || echo "Commit not accessible"

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 92


🏁 Script executed:

# Check what the parent repository actually has for the submodule pointer
git ls-files -s | grep Megatron-LM

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 141


🏁 Script executed:

# Also check if the new commit exists anywhere
cd 3rdparty/Megatron-LM && git log --all --oneline 2>/dev/null | grep b4e4d96 || echo "Commit b4e4d96 not found in local history"

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 112


🏁 Script executed:

# Check git diff to see what's being changed for the submodule
git diff HEAD 3rdparty/Megatron-LM 2>/dev/null | head -20

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 53


🏁 Script executed:

# Fetch all refs from the submodule remote to see available commits
cd 3rdparty/Megatron-LM && git fetch origin 2>&1 | head -20

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 53


🏁 Script executed:

# Now try to find the target commit
cd 3rdparty/Megatron-LM && git log --all --oneline --decorate 2>/dev/null | grep -E "(b4e4d96|3fa99b6)" | head -10

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 162


🏁 Script executed:

# Check if target commit exists on remote
cd 3rdparty/Megatron-LM && git ls-remote origin b4e4d9618e8dec4fe72adb231b56c209130df811 2>&1

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 53


Cannot verify submodule update—target commit is inaccessible.

The submodule pointer references commit b4e4d9618e8dec4fe72adb231b56c209130df811, but this commit is not accessible in the submodule repository. The current HEAD (3fa99b63a372b1d0ac3415f5dd50a035c8ee0fef) differs from the expected pointer, and the target commit cannot be found in local or remote history. Ensure the target commit exists on https://github.com/NVIDIA/Megatron-LM.git and is reachable before merging.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The submodule 3rdparty/Megatron-LM is
pointing to an unreachable commit b4e4d9618e8dec4fe72adb231b56c209130df811;
update the submodule reference to a reachable commit on the upstream repo (or
push the missing commit to https://github.com/NVIDIA/Megatron-LM.git), then
refresh the submodule state: in your local clone fetch the upstream for the
Megatron-LM submodule, check out the correct commit or branch, run git add
3rdparty/Megatron-LM and commit the updated gitlink so the repository points to
an accessible commit (ensure the updated commit replaces references to
b4e4d9618e8dec4fe72adb231b56c209130df811).

@svcnvidia-nemo-ci svcnvidia-nemo-ci deleted the bump-ci-container-2026-03-21-main-main branch March 21, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants