[doc] feat: Add FLOPs calculator and FP8/FP4 dequantization guidance to adding-model-support skill - #2934
Merged
Conversation
…to adding-model-support skill - Step 4 (Discovery): Check for quantized weights (FP8/FP4) that silently break models without dequantization. Documents standalone script and in-bridge hook approaches. - Phase 2: Update FLOPs calculator when new architectural blocks (GDN, MTP, Mamba) differ from standard attention/MLP. References PR #2925 as example. Signed-off-by: Chen Cui <chcui@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maybe_modify_loaded_hf_weight()hook.flop_utils.pyfor new blocks (GDN, MTP, Mamba, novel MoE), with reference to PR [perf] feat: add GDN (Gated DeltaNet) FLOPs calculator #2925 as the canonical example.Test plan
skills/adding-model-support/SKILL.mdexamples/models/vlm/ministral3/dequant_fp8_for_bridge.py, PR [perf] feat: add GDN (Gated DeltaNet) FLOPs calculator #2925) are correct