Skip to content

chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-03-19)#2901

Closed
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-03-19-main-dev
Closed

chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-03-19)#2901
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-03-19-main-dev

Conversation

@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Mar 19, 2026

🚀 PR to bump uv.lock in main.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to latest versions.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the needs-more-tests Requires additional L0 and L1 test coverage before merge label Mar 19, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor Author

/ok to test 504ae39

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 19, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

This PR updates the Megatron-LM submodule reference to a newer commit hash and updates the dev commit marker file. No code logic, control flow, or public APIs are modified.

Changes

Cohort / File(s) Summary
Submodule and Dev Configuration
.dev.commit, 3rdparty/Megatron-LM
Updated submodule pointer and commit marker reference to align with Megatron-LM upstream changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • yaoyu-33
  • maanug-nv
🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions bumping uv.lock but the actual changes are only to .dev.commit and a git submodule reference, with no modifications to uv.lock. Update the title to accurately reflect the actual changes, such as 'chore: Update .dev.commit and Megatron-LM submodule reference (2026-03-19)'.
Test Results For Major Changes ⚠️ Warning PR updates critical Megatron-LM submodule reference that could affect training numerics and convergence, but contains no test results or regression analysis despite being labeled 'needs-more-tests' and having an invalid commit hash. Document comprehensive test results verifying the updated Megatron-LM submodule doesn't cause regressions, run convergence and performance benchmarks, and replace the invalid commit hash with a valid one.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-03-19-main-dev
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

Flake8 can be used to improve the quality of Python code reviews.

Flake8 is a Python linter that wraps PyFlakes, pycodestyle and Ned Batchelder's McCabe script.

To configure Flake8, add a '.flake8' or 'setup.cfg' file to your project root.

See Flake8 Documentation for more details.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The PR currently updates the Megatron-LM submodule to a non-existent
commit (ebf1508100d4123293a242b84c76a937317d7894) and the title/description are
misleading; update the PR by replacing the invalid commit hash for the
Megatron-LM submodule with a valid, existing commit from that repository, change
the PR title and description to explicitly state "Update Megatron-LM submodule
to <new-commit>" (or similar), run and attach the required tests addressing the
"needs-more-tests" label, and include the test results and testing notes in the
PR description before resubmitting.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 178d389c-d518-4741-b310-f910459e569a

📥 Commits

Reviewing files that changed from the base of the PR and between f68e890 and 504ae39.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .dev.commit
  • 3rdparty/Megatron-LM

@@ -1 +1 @@
Subproject commit c4bffde9e56187c577ec6b9a355d9291bc3fa97a
Subproject commit ebf1508100d4123293a242b84c76a937317d7894
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the new submodule commit exists and show what changed

# Navigate to the submodule directory
cd 3rdparty/Megatron-LM || exit 1

# Fetch latest changes
git fetch origin

# Verify the new commit exists
if git cat-file -e ebf1508100d4123293a242b84c76a937317d7894 2>/dev/null; then
  echo "✓ Commit ebf1508100d4123293a242b84c76a937317d7894 exists"
  
  # Show the commit message
  echo -e "\n--- New commit details ---"
  git log -1 --oneline ebf1508100d4123293a242b84c76a937317d7894
  
  # Show changes between old and new commit (if old commit exists)
  if git cat-file -e c4bffde9e56187c577ec6b9a355d9291bc3fa97a 2>/dev/null; then
    echo -e "\n--- Changes summary ---"
    git log --oneline c4bffde9e56187c577ec6b9a355d9291bc3fa97a..ebf1508100d4123293a242b84c76a937317d7894 | head -20
  fi
else
  echo "✗ Commit ebf1508100d4123293a242b84c76a937317d7894 not found"
  exit 1
fi

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 130


PR contains invalid submodule reference and title mismatch—do not merge.

The PR title claims to "Bump uv.lock" but actually updates the Megatron-LM submodule. More critically, verification found that the target commit ebf1508100d4123293a242b84c76a937317d7894 does not exist in the Megatron-LM repository, making this change invalid and breaking the repository state for anyone who pulls it.

Before resubmitting:

  • Update the PR title and description to accurately reflect the submodule update
  • Replace the invalid commit hash with a valid, existing commit from Megatron-LM
  • Address the "needs-more-tests" label and ensure adequate testing is completed
  • Include test results or testing information in the PR description for this major change
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The PR currently updates the Megatron-LM
submodule to a non-existent commit (ebf1508100d4123293a242b84c76a937317d7894)
and the title/description are misleading; update the PR by replacing the invalid
commit hash for the Megatron-LM submodule with a valid, existing commit from
that repository, change the PR title and description to explicitly state "Update
Megatron-LM submodule to <new-commit>" (or similar), run and attach the required
tests addressing the "needs-more-tests" label, and include the test results and
testing notes in the PR description before resubmitting.

@yaoyu-33
Copy link
Copy Markdown
Contributor

Closing stale bot PR.

@yaoyu-33 yaoyu-33 closed this Mar 25, 2026
@yaoyu-33 yaoyu-33 deleted the bump-ci-container-2026-03-19-main-dev branch March 25, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-more-tests Requires additional L0 and L1 test coverage before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants