chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-03-19)#2901
chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-03-19)#2901svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
uv.lock (main, mcore-dev) (2026-03-19)#2901Conversation
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
/ok to test 504ae39 |
📝 WalkthroughWalkthroughThis PR updates the Megatron-LM submodule reference to a newer commit hash and updates the dev commit marker file. No code logic, control flow, or public APIs are modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip Flake8 can be used to improve the quality of Python code reviews.Flake8 is a Python linter that wraps PyFlakes, pycodestyle and Ned Batchelder's McCabe script. To configure Flake8, add a '.flake8' or 'setup.cfg' file to your project root. See Flake8 Documentation for more details. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The PR currently updates the Megatron-LM submodule to a non-existent
commit (ebf1508100d4123293a242b84c76a937317d7894) and the title/description are
misleading; update the PR by replacing the invalid commit hash for the
Megatron-LM submodule with a valid, existing commit from that repository, change
the PR title and description to explicitly state "Update Megatron-LM submodule
to <new-commit>" (or similar), run and attach the required tests addressing the
"needs-more-tests" label, and include the test results and testing notes in the
PR description before resubmitting.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 178d389c-d518-4741-b310-f910459e569a
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.dev.commit3rdparty/Megatron-LM
| @@ -1 +1 @@ | |||
| Subproject commit c4bffde9e56187c577ec6b9a355d9291bc3fa97a | |||
| Subproject commit ebf1508100d4123293a242b84c76a937317d7894 | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the new submodule commit exists and show what changed
# Navigate to the submodule directory
cd 3rdparty/Megatron-LM || exit 1
# Fetch latest changes
git fetch origin
# Verify the new commit exists
if git cat-file -e ebf1508100d4123293a242b84c76a937317d7894 2>/dev/null; then
echo "✓ Commit ebf1508100d4123293a242b84c76a937317d7894 exists"
# Show the commit message
echo -e "\n--- New commit details ---"
git log -1 --oneline ebf1508100d4123293a242b84c76a937317d7894
# Show changes between old and new commit (if old commit exists)
if git cat-file -e c4bffde9e56187c577ec6b9a355d9291bc3fa97a 2>/dev/null; then
echo -e "\n--- Changes summary ---"
git log --oneline c4bffde9e56187c577ec6b9a355d9291bc3fa97a..ebf1508100d4123293a242b84c76a937317d7894 | head -20
fi
else
echo "✗ Commit ebf1508100d4123293a242b84c76a937317d7894 not found"
exit 1
fiRepository: NVIDIA-NeMo/Megatron-Bridge
Length of output: 130
PR contains invalid submodule reference and title mismatch—do not merge.
The PR title claims to "Bump uv.lock" but actually updates the Megatron-LM submodule. More critically, verification found that the target commit ebf1508100d4123293a242b84c76a937317d7894 does not exist in the Megatron-LM repository, making this change invalid and breaking the repository state for anyone who pulls it.
Before resubmitting:
- Update the PR title and description to accurately reflect the submodule update
- Replace the invalid commit hash with a valid, existing commit from Megatron-LM
- Address the "needs-more-tests" label and ensure adequate testing is completed
- Include test results or testing information in the PR description for this major change
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@3rdparty/Megatron-LM` at line 1, The PR currently updates the Megatron-LM
submodule to a non-existent commit (ebf1508100d4123293a242b84c76a937317d7894)
and the title/description are misleading; update the PR by replacing the invalid
commit hash for the Megatron-LM submodule with a valid, existing commit from
that repository, change the PR title and description to explicitly state "Update
Megatron-LM submodule to <new-commit>" (or similar), run and attach the required
tests addressing the "needs-more-tests" label, and include the test results and
testing notes in the PR description before resubmitting.
|
Closing stale bot PR. |
🚀 PR to bump
uv.lockinmain.🤖 This PR will be merged automatically once CI passes.
Summary by CodeRabbit