Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .main.commit
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7ca9dc56b1e52a02b495493f2588c85e214b488e
f8becec65f47982c80c3d397bef7c3fba65f9efc
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the new Megatron-LM commit exists and get its details

# Check if the commit exists in the submodule
cd 3rdparty/Megatron-LM 2>/dev/null || {
  echo "Megatron-LM submodule not found at 3rdparty/Megatron-LM"
  exit 1
}

# Fetch the latest changes to ensure we have the commit
git fetch origin

# Verify the new commit exists and show details
echo "=== Checking new commit f8becec65f47982c80c3d397bef7c3fba65f9efc ==="
git cat-file -t f8becec65f47982c80c3d397bef7c3fba65f9efc 2>/dev/null || {
  echo "ERROR: Commit f8becec65f47982c80c3d397bef7c3fba65f9efc not found"
  exit 1
}

echo -e "\n=== Commit details ==="
git log -1 --oneline f8becec65f47982c80c3d397bef7c3fba65f9efc

echo -e "\n=== Checking old commit 7ca9dc56b1e52a02b495493f2588c85e214b488e ==="
git cat-file -t 7ca9dc56b1e52a02b495493f2588c85e214b488e 2>/dev/null || {
  echo "ERROR: Old commit 7ca9dc56b1e52a02b495493f2588c85e214b488e not found"
  exit 1
}

echo -e "\n=== Commits between old and new ==="
git log --oneline 7ca9dc56b1e52a02b495493f2588c85e214b488e..f8becec65f47982c80c3d397bef7c3fba65f9efc

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 204


🏁 Script executed:

git ls-files | head -20

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 739


🏁 Script executed:

cat .main.commit 2>/dev/null || echo "File not found"

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 111


🏁 Script executed:

git config --file .gitmodules --name-only --get-regexp path 2>/dev/null | head -20 || echo "No submodules found or .gitmodules doesn't exist"

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 106


🏁 Script executed:

fd ".main.commit" --type f

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 53


🏁 Script executed:

find . -name ".main.commit" -type f 2>/dev/null

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 85


🏁 Script executed:

git config --file .gitmodules --get submodule.3rdparty/Megatron-LM.url

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 112


🏁 Script executed:

cat .dev.commit

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 111


🏁 Script executed:

ls -la | grep "\.commit"

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 201


🏁 Script executed:

git submodule status

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 133


🌐 Web query:

site:github.com/NVIDIA/Megatron-LM commit f8becec65f47982c80c3d397bef7c3fba65f9efc

💡 Result:

Commit f8becec65f47982c80c3d397bef7c3fba65f9efc in NVIDIA/Megatron-LM is titled “Miscellaneous inference bug fixes (#3840)”, authored by Keshav Santhanam, dated Fri, Mar 13, 2026 17:49:46 -0700. [1]

It changes 9 files with 5,275 insertions and 4,762 deletions, mainly in Megatron Core inference dynamic context/engine and related Mamba metadata, plus updates to H100 test recipes and multiple inference unit/functional test fixtures (including a large update to golden_values_dev_dgx_h100.json). [1][2]

Sources: [1] [2]


Update PR description to accurately reflect changes.

The PR title and description mention bumping uv.lock, but the actual changes update .main.commit (tracking file for the Megatron-LM submodule) to commit f8becec65f47982c80c3d397bef7c3fba65f9efc. The new commit is a valid bug fix release ("Miscellaneous inference bug fixes #3840") from Megatron-LM and does not introduce breaking changes, but the PR metadata should be corrected to accurately describe what is being updated.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.main.commit at line 1, Update the PR title and description to accurately
reflect that the change updates the Megatron-LM submodule by bumping the tracked
commit in .main.commit to f8becec65f47982c80c3d397bef7c3fba65f9efc (a bugfix
release: "Miscellaneous inference bug fixes `#3840`") instead of saying it bumps
uv.lock; edit the PR title and body to mention updating the Megatron-LM
submodule commit and note that this is a non-breaking bugfix release, including
the commit hash f8becec65f47982c80c3d397bef7c3fba65f9efc for traceability.

2 changes: 1 addition & 1 deletion 3rdparty/Megatron-LM
Submodule Megatron-LM updated 29 files
+40 −0 docs/user-guide/data-preparation.md
+0 −8 megatron/core/enums.py
+16 −1 megatron/core/extensions/transformer_engine.py
+3 −3 megatron/core/inference/contexts/attention_context/mamba_metadata.py
+87 −45 megatron/core/inference/contexts/dynamic_context.py
+29 −5 megatron/core/inference/engines/dynamic_engine.py
+6 −2 megatron/core/inference/model_inference_wrappers/abstract_model_inference_wrapper.py
+2 −1 megatron/core/inference/text_generation_controllers/text_generation_controller.py
+6 −1 megatron/core/models/common/embeddings/rope_utils.py
+0 −9 megatron/core/pipeline_parallel/schedules.py
+6 −2 megatron/core/ssm/mamba_layer.py
+0 −9 megatron/core/transformer/enums.py
+6 −2 megatron/core/transformer/transformer_layer.py
+1 −0 pyproject.toml
+4,621 −4,619 ...test_cases/hybrid/hybrid_dynamic_inference_tp1_pp1_dp8_583m_chunked_prefill/golden_values_dev_dgx_h100.json
+2 −0 ...ctional_tests/test_cases/hybrid/hybrid_dynamic_inference_tp1_pp1_dp8_583m_chunked_prefill/model_config.yaml
+2 −2 tests/test_utils/recipes/h100/mamba-dynamic-inference.yaml
+34 −0 tests/unit_tests/data/test_preprocess_data.py
+48 −0 tests/unit_tests/inference/contexts/attention_metadata/test_mamba_metadata.py
+1,295 −0 tests/unit_tests/inference/contexts/test_dynamic_context.py
+911 −47 tests/unit_tests/inference/engines/test_dynamic_engine.py
+101 −2 tests/unit_tests/inference/test_batch_dimension_utils.py
+28 −40 tests/unit_tests/inference/test_data_parallel_inference_coordinator.py
+193 −0 tests/unit_tests/inference/test_stop_words.py
+286 −0 tests/unit_tests/inference/text_generation_controllers/test_text_generation_controller.py
+258 −0 tests/unit_tests/ssm/test_causal_conv1d_triton.py
+3 −0 tests/unit_tests/transformer/test_vision_cuda_graphs.py
+195 −120 tools/preprocess_data.py
+9 −10 uv.lock
Loading
Loading