[test] fix: temporarily disable qwen2.5 omni unit tests#2759
Merged
Conversation
Mark TestQwen25OmniModel with @pytest.mark.pleasefixme to skip in CI. The tests instantiate full-size HF vision/audio encoders which causes timeout (>50s). Needs to be refactored to use lightweight dummy stubs. Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com> Made-with: Cursor
Contributor
Author
|
/ok to test 6d6807e |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA pytest decorator ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Temporarily disables the
TestQwen25OmniModeltest class with@pytest.mark.pleasefixmeto unblock CI.Why?
The tests introduced in #2634 instantiate full-size HF vision and audio encoders (
Qwen2_5OmniVisionEncoder,Qwen2_5OmniAudioEncoder) at real Qwen2.5-Omni-7B dimensions.test_shared_embedding_or_output_weightconstructs two such models in a single test with a 50s timeout, which is causing CI timeouts on other PRs (e.g. #2004).Follow-up needed
Replace the full-size HF encoders with lightweight dummy stubs so the tests run fast and can be re-enabled. cc @yuekaizhang
Changelog
TestQwen25OmniModelwith@pytest.mark.pleasefixmeto skip in CIMade with Cursor
Summary by CodeRabbit