Skip to content

chore(beep boop 🤖): Bump uv.lock (main) (2026-03-10)#2719

Closed
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-03-10-main
Closed

chore(beep boop 🤖): Bump uv.lock (main) (2026-03-10)#2719
svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
bump-ci-container-2026-03-10-main

Conversation

@svcnvidia-nemo-ci
Copy link
Contributor

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Mar 10, 2026

🚀 PR to bump uv.lock in main.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated internal dependency version with no impact to user-facing functionality.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci
Copy link
Contributor Author

/ok to test 992388a

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 10, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

📝 Walkthrough

Walkthrough

Updates the 3rdparty/Megatron-LM submodule pointer from commit 77a00ec1 to commit 0e19bf11. No functional code changes or behavioral modifications are introduced by this update.

Changes

Cohort / File(s) Summary
Submodule Pointer Update
.gitmodules
Updated 3rdparty/Megatron-LM submodule reference to new commit (77a00ec → 0e19bf11).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • maanug-nv
  • yaoyu-33
  • ko3n1g
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to bump 'uv.lock' but the actual changeset only updates the Megatron-LM submodule pointer with no changes to uv.lock. Update the title to accurately reflect that this change is bumping the Megatron-LM submodule pointer, not uv.lock.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR updates only a submodule pointer with no functional code or behavioral changes; qualifies as minor change per documented criteria.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-ci-container-2026-03-10-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The PR title/description are inconsistent with the actual change: the
title mentions "Bump `uv.lock` (main)" but the diff updates the
3rdparty/Megatron-LM submodule pointer; update the PR metadata so the title and
description accurately reflect the change to the 3rdparty/Megatron-LM submodule
(or, if the intent was to bump uv.lock, revert the submodule change and adjust
the commit), and ensure the PR title, body, and any summary fields all reference
"3rdparty/Megatron-LM" when that is the actual change.
- Line 1: The repository's submodule pointer was updated to commit
0e19bf11f70483c18f058faff3d388186437fa30 but the .main.commit file was not
updated; add or update the .main.commit file at repo root to contain exactly
that commit hash (so scripts/switch_mcore.sh and
tests/unit_tests/training/test_mcore_commit.py see the new pinned commit),
ensuring the file content is the single hash string with a newline.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 58d19a85-9dc5-4225-a59b-d021394fda8a

📥 Commits

Reviewing files that changed from the base of the PR and between a44fff2 and 992388a.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • 3rdparty/Megatron-LM

@@ -1 +1 @@
Subproject commit 77a00ec1c993ea021a22d06650933d4bad9bd087
Subproject commit 0e19bf11f70483c18f058faff3d388186437fa30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent PR title and description.

The PR title mentions "Bump uv.lock (main)" but the actual change updates the 3rdparty/Megatron-LM submodule pointer. This appears to be a copy-paste error in the PR metadata that could confuse reviewers.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The PR title/description are inconsistent
with the actual change: the title mentions "Bump `uv.lock` (main)" but the diff
updates the 3rdparty/Megatron-LM submodule pointer; update the PR metadata so
the title and description accurately reflect the change to the
3rdparty/Megatron-LM submodule (or, if the intent was to bump uv.lock, revert
the submodule change and adjust the commit), and ensure the PR title, body, and
any summary fields all reference "3rdparty/Megatron-LM" when that is the actual
change.

⚠️ Potential issue | 🔴 Critical

Critical: .main.commit file must be updated to match the new submodule pointer.

The submodule pointer has been updated to 0e19bf11f70483c18f058faff3d388186437fa30, but the .main.commit file is not included in this PR. According to the test in tests/unit_tests/training/test_mcore_commit.py, the .main.commit file must stay in sync with the pinned submodule commit. Without this update, the test will fail and the scripts/switch_mcore.sh script will check out the old commit instead of the new one.

🔧 Required fix

Add the following file to this PR:

File: .main.commit

-77a00ec1c993ea021a22d06650933d4bad9bd087
+0e19bf11f70483c18f058faff3d388186437fa30

Or run this command at the repository root:

echo 0e19bf11f70483c18f058faff3d388186437fa30 > .main.commit

As per relevant code snippet from tests/unit_tests/training/test_mcore_commit.py:55-63, the test validates that .main.commit must stay in sync with the submodule pointer.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The repository's submodule pointer was
updated to commit 0e19bf11f70483c18f058faff3d388186437fa30 but the .main.commit
file was not updated; add or update the .main.commit file at repo root to
contain exactly that commit hash (so scripts/switch_mcore.sh and
tests/unit_tests/training/test_mcore_commit.py see the new pinned commit),
ensuring the file content is the single hash string with a newline.

@yaoyu-33 yaoyu-33 added area:build Dependencies, packaging, images, and environment setup needs-review PR is ready for code review and waiting on a reviewer labels Mar 10, 2026
@yaoyu-33 yaoyu-33 changed the title chore(beep boop 🤖): Bump uv.lock (main) (2026-03-10) [build] chore: bump uv.lock (main, 2026-03-10) Mar 10, 2026
@yaoyu-33 yaoyu-33 changed the title [build] chore: bump uv.lock (main, 2026-03-10) chore(beep boop 🤖): Bump uv.lock (main) (2026-03-10) Mar 10, 2026
mehraakash added a commit that referenced this pull request Mar 11, 2026
Replaces conflicting bump PR #2719. Updates 3rdparty/Megatron-LM from
8318b8093e7d to 0e19bf11f704 (8 new MCore commits). uv.lock unchanged
as transformers is already pinned to 5.2.0 in pyproject.toml.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mehraakash added a commit that referenced this pull request Mar 11, 2026
Replaces conflicting bump PR #2719. Updates 3rdparty/Megatron-LM from
8318b8093e7d to 0e19bf11f704 (8 new MCore commits). uv.lock unchanged
as transformers is already pinned to 5.2.0 in pyproject.toml.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Akash Mehra <akamehra@nvidia.com>
@yaoyu-33
Copy link
Contributor

Closing as stale.

@yaoyu-33 yaoyu-33 closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Dependencies, packaging, images, and environment setup needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants