chore(beep boop 🤖): Bump uv.lock (main) (2026-03-10)#2719
chore(beep boop 🤖): Bump uv.lock (main) (2026-03-10)#2719svcnvidia-nemo-ci wants to merge 1 commit intomainfrom
uv.lock (main) (2026-03-10)#2719Conversation
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
/ok to test 992388a |
📝 WalkthroughWalkthroughUpdates the 3rdparty/Megatron-LM submodule pointer from commit 77a00ec1 to commit 0e19bf11. No functional code changes or behavioral modifications are introduced by this update. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The PR title/description are inconsistent with the actual change: the
title mentions "Bump `uv.lock` (main)" but the diff updates the
3rdparty/Megatron-LM submodule pointer; update the PR metadata so the title and
description accurately reflect the change to the 3rdparty/Megatron-LM submodule
(or, if the intent was to bump uv.lock, revert the submodule change and adjust
the commit), and ensure the PR title, body, and any summary fields all reference
"3rdparty/Megatron-LM" when that is the actual change.
- Line 1: The repository's submodule pointer was updated to commit
0e19bf11f70483c18f058faff3d388186437fa30 but the .main.commit file was not
updated; add or update the .main.commit file at repo root to contain exactly
that commit hash (so scripts/switch_mcore.sh and
tests/unit_tests/training/test_mcore_commit.py see the new pinned commit),
ensuring the file content is the single hash string with a newline.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 58d19a85-9dc5-4225-a59b-d021394fda8a
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
3rdparty/Megatron-LM
| @@ -1 +1 @@ | |||
| Subproject commit 77a00ec1c993ea021a22d06650933d4bad9bd087 | |||
| Subproject commit 0e19bf11f70483c18f058faff3d388186437fa30 | |||
There was a problem hiding this comment.
Inconsistent PR title and description.
The PR title mentions "Bump uv.lock (main)" but the actual change updates the 3rdparty/Megatron-LM submodule pointer. This appears to be a copy-paste error in the PR metadata that could confuse reviewers.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@3rdparty/Megatron-LM` at line 1, The PR title/description are inconsistent
with the actual change: the title mentions "Bump `uv.lock` (main)" but the diff
updates the 3rdparty/Megatron-LM submodule pointer; update the PR metadata so
the title and description accurately reflect the change to the
3rdparty/Megatron-LM submodule (or, if the intent was to bump uv.lock, revert
the submodule change and adjust the commit), and ensure the PR title, body, and
any summary fields all reference "3rdparty/Megatron-LM" when that is the actual
change.
Critical: .main.commit file must be updated to match the new submodule pointer.
The submodule pointer has been updated to 0e19bf11f70483c18f058faff3d388186437fa30, but the .main.commit file is not included in this PR. According to the test in tests/unit_tests/training/test_mcore_commit.py, the .main.commit file must stay in sync with the pinned submodule commit. Without this update, the test will fail and the scripts/switch_mcore.sh script will check out the old commit instead of the new one.
🔧 Required fix
Add the following file to this PR:
File: .main.commit
-77a00ec1c993ea021a22d06650933d4bad9bd087
+0e19bf11f70483c18f058faff3d388186437fa30Or run this command at the repository root:
echo 0e19bf11f70483c18f058faff3d388186437fa30 > .main.commitAs per relevant code snippet from tests/unit_tests/training/test_mcore_commit.py:55-63, the test validates that .main.commit must stay in sync with the submodule pointer.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@3rdparty/Megatron-LM` at line 1, The repository's submodule pointer was
updated to commit 0e19bf11f70483c18f058faff3d388186437fa30 but the .main.commit
file was not updated; add or update the .main.commit file at repo root to
contain exactly that commit hash (so scripts/switch_mcore.sh and
tests/unit_tests/training/test_mcore_commit.py see the new pinned commit),
ensuring the file content is the single hash string with a newline.
uv.lock (main) (2026-03-10)uv.lock (main) (2026-03-10)
Replaces conflicting bump PR #2719. Updates 3rdparty/Megatron-LM from 8318b8093e7d to 0e19bf11f704 (8 new MCore commits). uv.lock unchanged as transformers is already pinned to 5.2.0 in pyproject.toml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces conflicting bump PR #2719. Updates 3rdparty/Megatron-LM from 8318b8093e7d to 0e19bf11f704 (8 new MCore commits). uv.lock unchanged as transformers is already pinned to 5.2.0 in pyproject.toml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Akash Mehra <akamehra@nvidia.com>
|
Closing as stale. |
🚀 PR to bump
uv.lockinmain.🤖 This PR will be merged automatically once CI passes.
Summary by CodeRabbit