Skip to content

build: Downgrade NVRx / Upgrade nemo-run#2623

Merged
ko3n1g merged 5 commits intomainfrom
ko3n1g/fix/nvrx-dgxc
Mar 4, 2026
Merged

build: Downgrade NVRx / Upgrade nemo-run#2623
ko3n1g merged 5 commits intomainfrom
ko3n1g/fix/nvrx-dgxc

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Mar 3, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Updated project dependencies configuration for build infrastructure management.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested a review from a team as a code owner March 3, 2026 13:21
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 3, 2026

📝 Walkthrough

Walkthrough

The pyproject.toml configuration is updated to add nemo-run as a project dependency via a git source. A new source entry for nemo-run is introduced that specifies a git URL with an explicit revision, and the dependency is added to the override-dependencies list.

Changes

Cohort / File(s) Summary
Dependency Configuration
pyproject.toml
Adds nemo-run as a git-based dependency with source and revision configuration in tool.uv.sources and override-dependencies; reformats urllib3 entry with inline comment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only dependency addition in pyproject.toml without modifications to core functionality, algorithms, or implementation logic.
Title check ✅ Passed The PR title 'build: Downgrade NVRx / Upgrade nemo-run' directly relates to the main change in pyproject.toml, which adds nemo-run as a dependency and modifies build configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ko3n1g/fix/nvrx-dgxc

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pyproject.toml`:
- Around line 119-121: pyproject.toml was changed to add/modify dependencies
("urllib3>=2.6.3" and "nemo-run @
git+https://github.com/NVIDIA/NeMo-Run.git@c1c3e920d4662c8188611263e18fd2e39e3c84f3")
but the uv.lock file was not regenerated; run the uv lock command (e.g., `uv
lock`) locally to regenerate uv.lock, verify the lockfile updated entries match
the new dependencies, and commit the updated uv.lock alongside the
pyproject.toml changes.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8eefcf and d59d348.

📒 Files selected for processing (1)
  • pyproject.toml

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
thomasdhc
thomasdhc previously approved these changes Mar 4, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r0.3.0 Cherry-pick label for r0.3.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants