Skip to content

nemotron3_nano_h100_fix_260201#2617

Merged
ko3n1g merged 1 commit intomainfrom
malay/nemotron3_nano_h100_fix_260201
Mar 3, 2026
Merged

nemotron3_nano_h100_fix_260201#2617
ko3n1g merged 1 commit intomainfrom
malay/nemotron3_nano_h100_fix_260201

Conversation

@malay-nagda
Copy link
Copy Markdown
Contributor

@malay-nagda malay-nagda commented Mar 3, 2026

What does this PR do ?

Fix Nemotron 3 Nano H100 configs.

Changelog

- NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100_BF16_V1 = BASE_NEMOTRON_3_NANO_CONFIG
- NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100_FP8_CS_V1 = BASE_NEMOTRON_3_NANO_CONFIG
+ NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100_BF16_V1 = _NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100
+ NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100_FP8_CS_V1 = _NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Restructured internal performance configuration management for improved maintainability.

Signed-off-by: Malay Nagda <malayn@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71768cd and 0da30fd.

📒 Files selected for processing (1)
  • scripts/performance/configs/nemotronh/nemotron_3_nano_workload_base_configs.py

📝 Walkthrough

Walkthrough

This PR refactors the Nemotron 3 Nano H100 pretraining configuration by introducing an internal helper config (_NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100) and redirecting two public H100 config constants to reference it, consolidating the base configuration definition.

Changes

Cohort / File(s) Summary
Nemotron Nano Config Refactoring
scripts/performance/configs/nemotronh/nemotron_3_nano_workload_base_configs.py
Introduced internal _NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100 configuration; updated NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100_BF16_V1 and NEMOTRON_3_NANO_PRETRAIN_CONFIG_H100_FP8_CS_V1 to reference the new internal config instead of directly using BASE_NEMOTRON_3_NANO_CONFIG.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

performance, r0.3.0

Suggested reviewers

  • erhoo82
  • tomlifu
🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Test Results For Major Changes ⚠️ Warning PR modifies training configuration parameters (batch sizes, GPU allocation, recomputation strategies) affecting numerical convergence and training behavior without including test results or convergence verification. Provide test results, convergence metrics, loss curves, and performance data validating the new configuration trains correctly without regressions.
Title check ❓ Inconclusive The title 'nemotron3_nano_h100_fix_260201' is vague and uses a date-based naming convention that doesn't clearly convey what was fixed or the nature of the change. Use a more descriptive title that clarifies the fix, such as 'Fix Nemotron 3 Nano H100 config references' or 'Update H100 config base references for Nemotron 3 Nano'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch malay/nemotron3_nano_h100_fix_260201

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ko3n1g ko3n1g merged commit 85ae70a into main Mar 3, 2026
60 checks passed
@ko3n1g ko3n1g deleted the malay/nemotron3_nano_h100_fix_260201 branch March 3, 2026 09:31
ko3n1g pushed a commit that referenced this pull request Mar 3, 2026
Signed-off-by: Malay Nagda <malayn@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@coderabbitai coderabbitai bot mentioned this pull request Mar 6, 2026
5 tasks
copy-pr-bot bot pushed a commit that referenced this pull request Mar 19, 2026
Signed-off-by: Malay Nagda <malayn@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance r0.3.0 Cherry-pick label for r0.3.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants