Fix lint and import error in perf script llama3_llm_finetune.py#2592
Merged
chtruong814 merged 1 commit intomainfrom Feb 27, 2026
Merged
Fix lint and import error in perf script llama3_llm_finetune.py#2592chtruong814 merged 1 commit intomainfrom
chtruong814 merged 1 commit intomainfrom
Conversation
This merged yesterday, which removed llama3_70b_finetune_config from that file b162358 This merged today but was a stale branch, still assuming llama3_70b_finetune_config was imported in that file #2397 Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change refactors LLAMA3 LoRA finetune configuration initialization by replacing two separate config constructors with a unified PEFT config approach, explicitly setting mixed precision, sequence length to 4096, and related configuration fields. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chtruong814
approved these changes
Feb 27, 2026
chtruong814
approved these changes
Feb 27, 2026
rhmukundan
approved these changes
Feb 27, 2026
malay-nagda
pushed a commit
that referenced
this pull request
Mar 2, 2026
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
malay-nagda
added a commit
that referenced
this pull request
Mar 2, 2026
… (#2608) Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Co-authored-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from convo with @chtruong814
This merged yesterday, which removed llama3_70b_finetune_config from that file b162358
This merged today but was a stale branch, still assuming llama3_70b_finetune_config was imported in that file #2397
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Summary by CodeRabbit