Skip to content

[ci] Add back ministral 3 tests#2577

Merged
chtruong814 merged 1 commit intomainfrom
chcui/ministral3_ci
Feb 27, 2026
Merged

[ci] Add back ministral 3 tests#2577
chtruong814 merged 1 commit intomainfrom
chcui/ministral3_ci

Conversation

@cuichenx
Copy link
Copy Markdown
Contributor

@cuichenx cuichenx commented Feb 27, 2026

What does this PR do ?

Add back ministral 3 tests now that transformers v5 update is complete.
Closes #2317

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Added ministral3 to automated CI/CD pipeline workflows for model and recipe validation.

Signed-off-by: Chen Cui <chcui@nvidia.com>
@cuichenx cuichenx requested a review from a team as a code owner February 27, 2026 01:28
@cuichenx cuichenx linked an issue Feb 27, 2026 that may be closed by this pull request
@cuichenx
Copy link
Copy Markdown
Contributor Author

/ok to test 4811951

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69a733e and 4811951.

📒 Files selected for processing (1)
  • .github/workflows/cicd-main.yml

📝 Walkthrough

Walkthrough

Adds ministral3 model and recipe support to CI/CD workflow matrices in the GitHub Actions pipeline. Two new script execution steps (L2_Launch_models_ministral3 and L2_Launch_recipes_ministral3) are inserted into corresponding functional test matrices.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/cicd-main.yml
Added two new matrix entries for ministral3 model and recipe functional test workflows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • yaoyu-33
  • thomasdhc
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[ci] Add back ministral 3 tests' directly and clearly describes the main change: re-enabling Ministral 3 tests in the CI workflow after the Transformers v5 update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor CI configuration changes (+2/-0 lines) re-enabling existing Ministral 3 tests after Transformers v5 upgrade.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chcui/ministral3_ci

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chtruong814 chtruong814 merged commit aca1816 into main Feb 27, 2026
96 of 98 checks passed
@chtruong814 chtruong814 deleted the chcui/ministral3_ci branch February 27, 2026 22:13
copy-pr-bot bot pushed a commit that referenced this pull request Mar 19, 2026
Signed-off-by: Chen Cui <chcui@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Ministral test to GHA

3 participants