Skip to content

fix formatting after 2416#2535

Closed
maanug-nv wants to merge 1 commit intomainfrom
maanug/fix-flops-formatting
Closed

fix formatting after 2416#2535
maanug-nv wants to merge 1 commit intomainfrom
maanug/fix-flops-formatting

Conversation

@maanug-nv
Copy link
Copy Markdown
Contributor

@maanug-nv maanug-nv commented Feb 25, 2026

What does this PR do ?

Seems lint check didn't run on #2416.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Refactor
    • Internal code optimization with no impact to user-facing functionality.

Signed-off-by: Maanu Grover <maanug@nvidia.com>
@maanug-nv maanug-nv enabled auto-merge (squash) February 25, 2026 22:50
@maanug-nv maanug-nv self-assigned this Feb 25, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa4a01b and 3eb88cb.

📒 Files selected for processing (1)
  • src/megatron/bridge/training/utils/flop_utils.py

📝 Walkthrough

Walkthrough

A multiline multiplication expression for model_flops_frozen in the LoRA branch of transformer_flops is refactored into a single-line form with identical terms and operands. No functional changes or control flow modifications.

Changes

Cohort / File(s) Summary
FLOPs Calculation Refactoring
src/megatron/bridge/training/utils/flop_utils.py
Collapsed multiline multiplication factor in LoRA branch into single-line expression while preserving identical computation logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

Run CICD

Suggested reviewers

  • guyueh1
  • erhoo82
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix formatting after 2416' is vague and lacks specificity about what was actually changed or formatted. Provide a more descriptive title that clearly indicates the specific formatting issue being fixed, such as 'Collapse multiline model_flops_frozen expression into single line' or 'Fix flop_utils.py formatting in LoRA branch'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Test Results For Major Changes ✅ Passed PR contains only minor formatting changes with no functional impact, affecting one file with net -5 lines and no alteration to control flow or logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch maanug/fix-flops-formatting

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@maanug-nv
Copy link
Copy Markdown
Contributor Author

Seems there are CI failures caused by #2416, so it has been reverted instead

@maanug-nv maanug-nv closed this Feb 25, 2026
auto-merge was automatically disabled February 25, 2026 23:57

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants