cp: Upgrade urllib3 to 2.6.3 (#2431) into r0.3.0#2439
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
📝 WalkthroughWalkthroughA build configuration update to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
120-120: Consider adding an upper-bound cap to the urllib3 override.
urllib3>=2.6.3is unbounded. If urllib3 3.x is released with breaking API changes, uv could resolve to it automatically. Other security overrides in this file (e.g.cryptography>=43.0.0,<47) use an upper bound for exactly this reason.🔒 Proposed cap
- "urllib3>=2.6.3", # To address CVE-2026-21441 + "urllib3>=2.6.3,<3", # To address CVE-2026-21441🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` at line 120, The urllib3 override is unbounded ("urllib3>=2.6.3") and could allow an incompatible future major release; update the requirement string in pyproject.toml to add an upper bound (for example change "urllib3>=2.6.3" to "urllib3>=2.6.3,<3") so it pins to the current major and prevents automatic resolution to a breaking 3.x release; make this edit where the dependency string "urllib3>=2.6.3" appears.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Line 120: The urllib3 override is unbounded ("urllib3>=2.6.3") and could allow
an incompatible future major release; update the requirement string in
pyproject.toml to add an upper bound (for example change "urllib3>=2.6.3" to
"urllib3>=2.6.3,<3") so it pins to the current major and prevents automatic
resolution to a breaking 3.x release; make this edit where the dependency string
"urllib3>=2.6.3" appears.
What does this PR do ?
cp: Upgrade urllib3 to 2.6.3 (#2431) into
r0.3.0Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Summary by CodeRabbit