Skip to content

build: Add setup.py to first layers#2421

Merged
ko3n1g merged 1 commit intor0.3.0from
ko3n1g/cp/e888f334b40493549f3b97696fcadf2621fa4275
Feb 18, 2026
Merged

build: Add setup.py to first layers#2421
ko3n1g merged 1 commit intor0.3.0from
ko3n1g/cp/e888f334b40493549f3b97696fcadf2621fa4275

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Feb 18, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Updated Docker CI build configuration to include additional setup files in the container image.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The Dockerfile.ci was updated to copy both Megatron-LM/setup.py and Megatron-LM/pyproject.toml into the image build context, expanding the existing COPY instruction to include an additional file needed for Megatron-LM setup.

Changes

Cohort / File(s) Summary
Docker Build Configuration
docker/Dockerfile.ci
Expanded COPY instruction to include setup.py alongside pyproject.toml when copying Megatron-LM files into the Docker image.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

r0.3.0

Suggested reviewers

  • thomasdhc
  • chtruong814
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: adding setup.py to the Docker build's first layers for improved build caching.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor build configuration changes (±1 line) to Docker setup without runtime impact, qualifying for test documentation exemption.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ko3n1g/cp/e888f334b40493549f3b97696fcadf2621fa4275

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ko3n1g ko3n1g merged commit 11e0db2 into r0.3.0 Feb 18, 2026
13 of 14 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/cp/e888f334b40493549f3b97696fcadf2621fa4275 branch February 18, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant