Skip to content

build: Bump TE on 2.12#2333

Merged
ko3n1g merged 2 commits intomainfrom
ko3n1g/build/bump-te-212-2
Feb 11, 2026
Merged

build: Bump TE on 2.12#2333
ko3n1g merged 2 commits intomainfrom
ko3n1g/build/bump-te-212-2

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Feb 11, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Updated transformer-engine dependency to a newer version.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested a review from a team as a code owner February 11, 2026 18:56
@ko3n1g ko3n1g added the r0.3.0 Cherry-pick label for r0.3.0 release branch label Feb 11, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

The transformer-engine dependency git commit hash in pyproject.toml is updated from d9b7fc5770a88af06e2e9c2bd97b550614c3a69f to 5671fd3675906cda1ade26c24a65d3dedd88eb89 in the uv override-dependencies configuration.

Changes

Cohort / File(s) Summary
Dependency Override Update
pyproject.toml
Updated transformer-engine git commit hash in [tool.uv].override-dependencies to point to a new commit.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • chtruong814
  • thomasdhc
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Test Results For Major Changes ⚠️ Warning PR contains critical transformer-engine dependency upgrade affecting FP8 training and numerics, plus extensive CI/CD infrastructure changes, but description lacks test results, validation, or regression confirmation. Complete PR description with comprehensive testing documentation including numerical stability validation, performance benchmarks, convergence confirmation, and CI/CD results for transformer-engine upgrade.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'build: Bump TE on 2.12' clearly describes the main change: updating the Transformer Engine (TE) dependency in the build configuration for version 2.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ko3n1g/build/bump-te-212-2

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g merged commit ca9492b into main Feb 11, 2026
59 of 61 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/build/bump-te-212-2 branch February 11, 2026 21:05
ko3n1g added a commit that referenced this pull request Feb 11, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
ko3n1g added a commit that referenced this pull request Feb 11, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Co-authored-by: Maanu Grover <109391026+maanug-nv@users.noreply.github.com>
ko3n1g added a commit that referenced this pull request Feb 14, 2026
@coderabbitai coderabbitai bot mentioned this pull request Mar 11, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r0.3.0 Cherry-pick label for r0.3.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants