Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docker/Dockerfile.ci
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ ENV UV_LINK_MODE=copy
ENV UV_VERSION="0.7.2"

RUN curl -LsSf https://astral.sh/uv/${UV_VERSION}/install.sh | sh && \
uv venv ${UV_PROJECT_ENVIRONMENT} --system-site-packages
uv venv ${UV_PROJECT_ENVIRONMENT} --system-site-packages && \
# Address CVE-2025-68973
apt-get update && apt install -y --only-upgrade gnupg && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use apt-get install instead of apt install in Dockerfiles.

apt is intended for interactive use and may emit warnings in non-interactive contexts (e.g., "WARNING: apt does not have a stable CLI interface"). The same line already uses apt-get update, so this is also an inconsistency.

Proposed fix
-    apt-get update && apt install -y --only-upgrade gnupg && \
+    apt-get update && apt-get install -y --only-upgrade gnupg && \
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
apt-get update && apt install -y --only-upgrade gnupg && \
apt-get update && apt-get install -y --only-upgrade gnupg && \
🤖 Prompt for AI Agents
In `@docker/Dockerfile.ci` at line 29, Replace the interactive apt command with
the non-interactive apt-get variant: change the occurrence of "apt install -y
--only-upgrade gnupg" to use "apt-get install -y --only-upgrade gnupg" so the
Dockerfile uses a consistent, stable CLI (matching the existing "apt-get
update") and avoids apt warnings in CI.

apt-get clean && \
rm -rf /var/lib/apt/lists/*

COPY pyproject.toml uv.lock /opt/Megatron-Bridge/
COPY src/megatron/bridge/__init__.py src/megatron/bridge/package_info.py /opt/Megatron-Bridge/src/megatron/bridge/
Expand Down
Loading