Skip to content

cp: mlflow upgrade#2281

Merged
ko3n1g merged 3 commits intor0.3.0from
ko3n1g/cp/mlflow-upgrade
Feb 9, 2026
Merged

cp: mlflow upgrade#2281
ko3n1g merged 3 commits intor0.3.0from
ko3n1g/cp/mlflow-upgrade

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Feb 9, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Updated MLflow dependency to version 3.5.0 or higher.
    • Added cryptography library to project dependencies.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
thomasdhc
thomasdhc previously approved these changes Feb 9, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

This pull request updates the Python project dependencies by bumping mlflow from version >=3.2.0 to >=3.5.0 across both the main dependencies and the uv override-dependencies section, and introduces a new cryptography dependency with version constraints >=43.0.0,<47.

Changes

Cohort / File(s) Summary
Dependency Updates
pyproject.toml
Bumps mlflow from >=3.2.0 to >=3.5.0 in dependencies and uv override-dependencies sections; adds new cryptography>=43.0.0,<47 constraint to uv override-dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

r0.3.0, Run CICD, cherry-pick

Suggested reviewers

  • thomasdhc
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'cp: mlflow upgrade' is partially related to the changeset but lacks clarity and specificity about the actual scope of changes. Consider a more descriptive title such as 'chore: upgrade mlflow to >=3.5.0 and add cryptography override' to better communicate the specific version change and additional dependency added.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed The pull request contains only minor dependency version updates to pyproject.toml with no modifications to application code, logic, or control flow. Since these are minor changes without code logic alterations, test results are not required.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ko3n1g/cp/mlflow-upgrade

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
pyproject.toml (1)

116-116: Clarify the reason for the new cryptography override.

Adding cryptography>=43.0.0,<47 as an override suggests a transitive dependency conflict or a security pin. Consider adding a brief inline comment (similar to the existing comments on other overrides) explaining why this constraint is needed — e.g., whether it resolves a resolution conflict introduced by the mlflow bump or addresses a known vulnerability range.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g merged commit b39bd94 into r0.3.0 Feb 9, 2026
51 of 53 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/cp/mlflow-upgrade branch February 9, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants