Skip to content

fix: Use nargs for custom_bash_cmds #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ko3n1g merged 4 commits into from
Feb 6, 2026
+7 −6
Merged

fix: Use nargs for custom_bash_cmds #2261

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b74eee6
fix: Use nargs
ko3n1g Feb 6, 2026
744f2ea
fix
ko3n1g Feb 6, 2026
a8ea624
generalize
ko3n1g Feb 6, 2026
a095c54
default
ko3n1g Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/performance/argument_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,8 @@ def parse_cli_args():
slurm_args.add_argument(
"-cb",
"--custom_bash_cmds",
type=list_of_strings,
help="Comma separated string of bash commands",
nargs="*",
help="List of bash commands to execute before the main command",
default=[],

@malay-nagda malay-nagda Feb 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep None as default or change the condition in scripts/performance/utils/executors.py that currently checks for None?

)
slurm_args.add_argument(
Expand Down
4 changes: 2 additions & 2 deletions scripts/performance/utils/executors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,11 @@ def slurm_executor(
numa_cmd = f"numactl --cpunodebind=$((SLURM_LOCALID/{numa_divisor})) --membind=$((SLURM_LOCALID/{numa_divisor}))"
if gpu.lower() in ["b300"]:
numa_cmd += " -C $((SLURM_LOCALID * 16)),$((SLURM_LOCALID * 16 + 1))"
custom_bash_cmds.append(numa_cmd)
custom_bash_cmds.append(f" ; {numa_cmd}")

launcher = SlurmTemplate(
template_inline=INLINE_TEMPLATE,
template_vars={"pre_cmds": " ; ".join(custom_bash_cmds)},
template_vars={"pre_cmds": " ".join(custom_bash_cmds)},
Comment thread
malay-nagda marked this conversation as resolved.
Outdated
)

executor = run.SlurmExecutor(
Expand Down
Loading