Skip to content

fix: fixing fsdp_manual_registration logic in perf script #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youngeunkwon0405 merged 1 commit into from
Feb 5, 2026
Merged

fix: fixing fsdp_manual_registration logic in perf script #2223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/performance/utils/overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def _set_nccl_ub_overrides(recipe: ConfigContainer, nccl_ub: bool = False) -> Co
# To enable symmetric kernels, average_in_collective must be disabled.
recipe.ddp.average_in_collective = False

if recipe.ddp.use_megatron_fsdp:
if recipe.ddp.use_megatron_fsdp and recipe.ddp.nccl_ub:
recipe.ddp.fsdp_manual_registration = True

return recipe
Expand Down
Loading