Skip to content

Fix typo in MTP doc#2222

Merged
cuichenx merged 1 commit intomainfrom
chcui/mtp_typo
Feb 6, 2026
Merged

Fix typo in MTP doc#2222
cuichenx merged 1 commit intomainfrom
chcui/mtp_typo

Conversation

@cuichenx
Copy link
Copy Markdown
Contributor

@cuichenx cuichenx commented Feb 4, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Documentation
    • Updated code examples in the training documentation to use consistent parameter naming conventions.

Signed-off-by: Chen Cui <chcui@nvidia.com>
@cuichenx cuichenx requested a review from yaoyu-33 February 4, 2026 22:50
@cuichenx cuichenx added the docs-only With great power comes great responsibility. label Feb 4, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Documentation update replacing historical config parameter naming with canonical cfg variable name in multi-token prediction configuration code examples.

Changes

Cohort / File(s) Summary
Documentation Updates
docs/training/multi-token-prediction.md
Renamed parameter from config to cfg in pretrain function calls within code examples (2 occurrences).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

docs-only

Suggested reviewers

  • yaoyu-33
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix typo in MTP doc' directly and accurately describes the main change: correcting parameter name references (config to cfg) in the MTP documentation file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed Documentation typo fix correcting parameter names from 'config' to 'cfg' in MTP code examples. Minor change with no runtime impact.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chcui/mtp_typo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cuichenx cuichenx merged commit 57d4760 into main Feb 6, 2026
22 checks passed
@cuichenx cuichenx deleted the chcui/mtp_typo branch February 6, 2026 22:31
sowmen pushed a commit to sowmen/Megatron-Bridge that referenced this pull request Feb 11, 2026
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: sowmen <sowmendipta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-only With great power comes great responsibility.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants