[sync] clear aux losses tracker after eval, add cuda graph validation - #2136
Open
ananthsub wants to merge 1 commit into
Open
[sync] clear aux losses tracker after eval, add cuda graph validation#2136ananthsub wants to merge 1 commit into
ananthsub wants to merge 1 commit into
Conversation
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Contributor
Author
|
/ok to test e3c39a8 |
Contributor
📝 WalkthroughWalkthroughThis PR adds runtime validation to enforce NCCL_GRAPH_REGISTER=0 when using CUDA graphs with Transformer Engine and expandable segments configured, and introduces MoE auxiliary loss tracker cleanup at evaluation boundaries to prevent metric leakage. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tests/unit_tests/training/test_config.py`:
- Around line 1143-1174: The new test function
test_cuda_graph_transformer_engine_expandable_segments_validation is missing a
pytest mark; add a class/function decorator such as `@pytest.mark.unit` (or the
appropriate category per guidelines) immediately above the def line and ensure
pytest is imported at the top of the file (add "import pytest" if absent); keep
the decorator placement consistent with other tests in the file so the test is
properly categorized by the test runner.
| ) | ||
|
|
||
| # CUDA graph with transformer_engine: validate NCCL_GRAPH_REGISTER when using expandable_segments | ||
| if self.model.cuda_graph_impl == "transformer_engine": |
Contributor
There was a problem hiding this comment.
Can we do this in the post_init in TransformerConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Sync training changes from NVIDIA/Megatron-LM#3056
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.