Conversation
… distillation, decentralized_pg Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
|
/ok to test f723594 |
📝 WalkthroughWalkthroughThis PR updates script path references across documentation and example files from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/models/vlm/qwen_vl/data/convert_to_qwenvl_wds.py (1)
18-24: Useuv runin the example command.
The updated path is correct, but the invocation should useuv runper repo guidance for example scripts.🔧 Proposed change
-python examples/models/vlm/qwen_vl/data/convert_to_qwenvl_wds.py \\ +uv run python examples/models/vlm/qwen_vl/data/convert_to_qwenvl_wds.py \\As per coding guidelines: Use 'uv run' to execute scripts instead of activating a virtual environment and calling 'python' directly.
🧹 Nitpick comments (1)
README.md (1)
124-124: Keep the Project Structure section consistent with the new examples layout.
Since this bullet now points toexamples/models, consider updating the Project Structure block (later in the README) so it no longer listsexamples/recipesand reflectsdistillation/decentralized_pgas well.✍️ Suggested README adjustment (outside this hunk)
-├── examples/ -│ ├── models/ # Bridge usage examples -│ └── recipes/ # Training examples +├── examples/ +│ ├── models/ # Model training examples +│ ├── distillation/ # Distillation workflows +│ └── decentralized_pg/ # Decentralized process group examples
|
|
||
| ```bash | ||
| torchrun --nproc-per-node=8 examples/recipes/ministral3/finetune_ministral3_vl.py \ | ||
| torchrun --nproc-per-node=8 examples/models/vlm/ministral3/finetune_ministral3_vl.py \ |
There was a problem hiding this comment.
just realized there's no finetune_ministral3_vl.py in the repo
Summary
Restructures the
examples/folder for better organization:Changes
examples/decentralized_pg/- Moved fromexamples/recipes/decentralized_pg/(top-level for decentralized process groups examples)examples/distillation/llama/- NEW folder for distillation workflowsexamples/models/- Extended with model training recipes:nemotron_3/- LLM training (moved from recipes)qwen3_next/- LLM training (moved from recipes)vlm/nemotron_vl/- VLM training (moved from recipes)vlm/qwen_vl/- VLM training (moved from recipes)Documentation Updates
Updated all paths in documentation files to reflect the new structure:
docs/training/distillation.mddocs/models/vlm/qwen3-vl.mddocs/models/vlm/qwen2.5-vl.mddocs/models/vlm/nemotron-nano-v2-vl.mddocs/models/vlm/ministral3.mddocs/models/llm/nemotron3.mddocs/models/llm/nemotronh.mddocs/recipe-usage.mddocs/megatron-lm-to-megatron-bridge.mdREADME.mdSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.