[sync] Fine-grained activation offloading - #2122
Merged
Merged
Conversation
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Contributor
Author
|
/ok to test fe3d2b2 |
Contributor
📝 WalkthroughWalkthroughThis change introduces fine-grained activation offloading validation and runtime setup. A new validator ensures the feature is only enabled with transformer_engine and meets version-specific Transformer Engine requirements (NVTE_CPU_OFFLOAD_V1 environment variable for TE ≥ 2.10.0). During setup, CPU affinity is configured when the feature is active. Unit tests validate all constraint scenarios. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yaoyu-33
approved these changes
Jan 29, 2026
conver334
pushed a commit
to conver334/Megatron-Bridge
that referenced
this pull request
Jan 30, 2026
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: conver334 <conver334@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Sync with changes from NVIDIA/Megatron-LM#1913
Enable CPU affinity when fine-grained activation offloading is enabled
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.