Conversation
Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
📝 WalkthroughWalkthroughThe change refines model-specific environment variable gating conditions in the performance plugins module. It updates checks for Llama-based models by changing model_family_name comparisons from specific subversions (llama31, llama3) to a unified "llama" check, affecting when hardware-specific NCCL and cuDNN optimizations are applied during pretraining. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
malay-nagda
approved these changes
Jan 26, 2026
nv-mollys
pushed a commit
that referenced
this pull request
Jan 27, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: mollys <mollys@mollys.nvidia.com>
aroshanghias-nvd
pushed a commit
to aroshanghias-nvd/Megatron-Bridge
that referenced
this pull request
Jan 29, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Ali Roshan Ghias <aroshanghias@nvidia.com>
aroshanghias-nvd
pushed a commit
to aroshanghias-nvd/Megatron-Bridge
that referenced
this pull request
Jan 29, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Ali Roshan Ghias <aroshanghias@nvidia.com>
This was referenced Feb 3, 2026
Merged
This was referenced Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.