Merged
Conversation
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
yaoyu-33
reviewed
Jan 29, 2026
yaoyu-33
previously approved these changes
Jan 29, 2026
Signed-off-by: Chen Cui <chcui@nvidia.com>
yaoyu-33
approved these changes
Jan 29, 2026
5 tasks
This was referenced Feb 3, 2026
5 tasks
This was referenced Feb 8, 2026
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Support THD Training in VLMs
TODOs
GLM 4.5 v(after this PR)Qwen 2.5 VL(after this PR)Qwen 3 VL(wip in Support qwen3-vl for THD format and CP #1943)Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Gemma 3 VL: Loss and grad norm are both matching closely between cp1 and cp2, for both BSHD and THD.
MInistral 3: Not sure why grad norm is different between cp1 and cp2. It might be a display issue. I will look into this further. Loss is matching very closely between cp1 and cp2, for both BSHD and THD.

Summary by CodeRabbit
New Features
Refactor
Tests
✏️ Tip: You can customize this high-level summary in your review settings.