[LoRA] Fix LoRA merge and support CanonicalLoRA merge#1603
Merged
yaoyu-33 merged 4 commits intoNVIDIA-NeMo:mainfrom Dec 12, 2025
Merged
[LoRA] Fix LoRA merge and support CanonicalLoRA merge#1603yaoyu-33 merged 4 commits intoNVIDIA-NeMo:mainfrom
yaoyu-33 merged 4 commits intoNVIDIA-NeMo:mainfrom
Conversation
7 tasks
Contributor
Author
yaoyu-33
reviewed
Dec 5, 2025
yaoyu-33
reviewed
Dec 5, 2025
yaoyu-33
reviewed
Dec 5, 2025
yaoyu-33
reviewed
Dec 6, 2025
yaoyu-33
reviewed
Dec 6, 2025
21fc42e to
a393bdb
Compare
Previous LoRA merge contains several errors: - It didn't handle fused QKV/gate up correctly - The handling of PP gathering is problematic Signed-off-by: Hollow Man <hollowman@opensuse.org>
a393bdb to
37b2a2e
Compare
Contributor
Author
|
Now this PR is refactored for better support of future LoRA bridge, we first construct the |
Contributor
|
/ok to test 37b2a2e |
yaoyu-33
reviewed
Dec 7, 2025
yaoyu-33
reviewed
Dec 7, 2025
yaoyu-33
reviewed
Dec 7, 2025
yaoyu-33
reviewed
Dec 7, 2025
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Signed-off-by: Hollow Man <hollowman@opensuse.org>
yaoyu-33
approved these changes
Dec 7, 2025
Contributor
|
/ok to test 19c4c5e |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do ?
Previous LoRA merge #1310 contains several errors, this PR aims to fix it and support CanonicalLoRA merge
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
✨ Presented to you with Mind Lab - A Lab for Experiential Intelligence.