Skip to content

Fix error when Megatron has vocab padding - #1473

Merged
yaoyu-33 merged 4 commits into
NVIDIA-NeMo:mainfrom
fzyzcjy:feat/vocab_pad
May 20, 2026
Merged

Fix error when Megatron has vocab padding#1473
yaoyu-33 merged 4 commits into
NVIDIA-NeMo:mainfrom
fzyzcjy:feat/vocab_pad

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

w/o this, I see error when megatron has vocab paddings since the shape does not match

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@copy-pr-bot

copy-pr-bot Bot commented Nov 23, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@fzyzcjy
cp
98d4da9 
Signed-off-by: fzyzcjy <ch271828n@outlook.com>
@ananthsub
ananthsub requested a review from yaoyu-33 December 8, 2025 22:09
@svcnvidia-nemo-ci svcnvidia-nemo-ci added waiting-on-maintainers Waiting on maintainers to respond and removed needs-follow-up labels Apr 21, 2026
@yaoyu-33 yaoyu-33 added area:ckpt Checkpoint conversion, loading, export, and save paths bug Something isn't working labels May 12, 2026
@yaoyu-33 yaoyu-33 added ready-to-merge PR is approved, current, and only waiting for CI to pass before merge and removed waiting-on-maintainers Waiting on maintainers to respond labels May 13, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label May 13, 2026
@yaoyu-33 yaoyu-33 removed the waiting-on-maintainers Waiting on maintainers to respond label May 13, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label May 14, 2026
@yaoyu-33 yaoyu-33 removed the ready-to-merge PR is approved, current, and only waiting for CI to pass before merge label May 14, 2026
@aroshanghias-nvd

aroshanghias-nvd commented May 19, 2026

Copy link
Copy Markdown
Contributor

/ok to test 3b99f7c

@aroshanghias-nvd

aroshanghias-nvd commented May 19, 2026

Copy link
Copy Markdown
Contributor

/ok to test d13dcb9

@aroshanghias-nvd
aroshanghias-nvd enabled auto-merge (squash) May 19, 2026 22:44
@cuichenx
cuichenx disabled auto-merge May 19, 2026 23:27
@yaoyu-33
yaoyu-33 merged commit 0feea9b into NVIDIA-NeMo:main May 20, 2026
73 of 74 checks passed
vasunvidia pushed a commit to vasunvidia/Megatron-Bridge that referenced this pull request Jun 10, 2026
@fzyzcjy @vasunvidia
Fix error when Megatron has vocab padding (NVIDIA-NeMo#1473)
a53d48d 
Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
@yaoyu-33 yaoyu-33 mentioned this pull request Aug 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaoyu-33 yaoyu-33 yaoyu-33 approved these changes

Assignees

No one assigned

Labels

area:ckpt Checkpoint conversion, loading, export, and save paths bug Something isn't working community-request waiting-on-maintainers Waiting on maintainers to respond

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fzyzcjy @aroshanghias-nvd @yaoyu-33 @chtruong814 @svcnvidia-nemo-ci