Conversation
Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
Contributor
Author
|
/ok to test 2426242 |
ananthsub
reviewed
Oct 30, 2025
Comment on lines
+196
to
+217
| # Sanitize config for WandB by doing a JSON round-trip | ||
| # This ensures all objects are converted to basic Python types that WandB can handle | ||
| def safe_serialize(obj): | ||
| """Safely convert any object to a JSON-serializable type. | ||
|
|
||
| Handles objects with broken __str__ or __repr__ methods that return | ||
| non-string types (e.g., PipelineParallelLayerLayout returns list). | ||
| """ | ||
| try: | ||
| # Try str() first | ||
| result = str(obj) | ||
| # Verify it actually returns a string | ||
| if not isinstance(result, str): | ||
| # __str__ returned non-string type, use type name instead | ||
| return f"<{type(obj).__name__}>" | ||
| return result | ||
| except Exception: | ||
| # __str__ raised an exception, use type name as fallback | ||
| return f"<{type(obj).__name__}>" | ||
|
|
||
| config_dict = self.cfg.to_dict() | ||
| sanitized_config = json.loads(json.dumps(config_dict, default=safe_serialize)) |
Contributor
There was a problem hiding this comment.
did you see any errors with checkpoint saving as well? or was this only an issue with wandb?
Contributor
Author
There was a problem hiding this comment.
checkpoint is fine I only observed this serialization issue with wandb.
Contributor
Author
There was a problem hiding this comment.
the root cause of this is the pp layout which is a list
ananthsub
approved these changes
Oct 30, 2025
chtruong814
pushed a commit
that referenced
this pull request
Oct 31, 2025
Signed-off-by: Ao Tang <aot@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serialization requires for pp layout