Skip to content

followup to add tests for tokenizer changes in #969 - #1033

Merged
ananthsub merged 1 commit into
NVIDIA-NeMo:mainfrom
ananthsub:tokenizer-test
Oct 28, 2025
Merged

followup to add tests for tokenizer changes in #969#1033
ananthsub merged 1 commit into
NVIDIA-NeMo:mainfrom
ananthsub:tokenizer-test

Conversation

@ananthsub

@ananthsub ananthsub commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

improve test coverage for eos property + null multimodal tokenizer introduced in sync #969

@ananthsub
followup to add tests for tokenizer changes in NVIDIA-NeMo#969
ef98b72 
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 22, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ananthsub

ananthsub commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test ef98b72

@ananthsub
ananthsub requested review from dimapihtar and maanug-nv and removed request for maanug-nv October 22, 2025 15:50
@ananthsub
ananthsub marked this pull request as ready for review October 22, 2025 15:50
@ananthsub
ananthsub enabled auto-merge (squash) October 22, 2025 15:50
dimapihtar
dimapihtar approved these changes Oct 28, 2025
View reviewed changes

@dimapihtar dimapihtar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ananthsub
ananthsub merged commit 4373271 into NVIDIA-NeMo:main Oct 28, 2025
41 of 43 checks passed
paul-gibbons pushed a commit to paul-gibbons/Megatron-Bridge that referenced this pull request Oct 29, 2025
@ananthsub @paul-gibbons
followup to add tests for tokenizer changes in NVIDIA-NeMo#969 (NVIDI…
0b9c62a 
…A-NeMo#1033)

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
paul-gibbons pushed a commit to paul-gibbons/Megatron-Bridge that referenced this pull request Oct 29, 2025
@ananthsub @paul-gibbons
followup to add tests for tokenizer changes in NVIDIA-NeMo#969 (NVIDI…
2af0fc3 
…A-NeMo#1033)

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
nv-mollys pushed a commit that referenced this pull request Oct 31, 2025
@ananthsub mollys
followup to add tests for tokenizer changes in #969 (#1033)
42d5fcf 
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: mollys <mollys@mollys.nvidia.com>
@yaoyu-33 yaoyu-33 added ci CI, automation, test queue, or workflow infrastructure work and removed testing labels Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimapihtar dimapihtar dimapihtar approved these changes

Assignees

No one assigned

Labels

ci CI, automation, test queue, or workflow infrastructure work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ananthsub @dimapihtar @yaoyu-33