Skip to content

cp: Remove lru_cache decorator from finetune dataset building (1012) into r0.2.0 #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ananthsub merged 1 commit into from
Oct 23, 2025
Merged

cp: Remove lru_cache decorator from finetune dataset building (1012) into r0.2.0 #1021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/megatron/bridge/data/builders/finetuning_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
# limitations under the License.

import logging
from functools import lru_cache
from pathlib import Path
from typing import Any, Optional, Union

Expand Down Expand Up @@ -178,7 +177,6 @@ def _build_datasets(self) -> list[Optional[Any]]:

return [train_ds, valid_ds, test_ds]

@lru_cache
def _create_dataset(
self,
path: Union[str, Path],
Expand Down