Skip to content

Add metrics conflict error FAQ to Readme #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bxyu-nvidia merged 4 commits into from
Oct 8, 2025
Merged

Add metrics conflict error FAQ to Readme #93

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36518ec
Add metrics conflict faq to readme
fsiino-nvidia Sep 24, 2025
b260662
Update error message
fsiino-nvidia Sep 25, 2025
3af9d15
Remove writeup from readme
fsiino-nvidia Sep 25, 2025
c7ffa94
Merge remote-tracking branch 'github/main' into fsiino/readme-faq-met…
fsiino-nvidia Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions nemo_gym/train_data_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,14 @@ def validate_samples_and_aggregate_metrics(

if conflicting_fpaths:
conflicting_fpaths_str = "\n- ".join([""] + conflicting_fpaths)
raise ValueError(f"Found conflicting aggregate metrics that need to be corrected:{conflicting_fpaths_str}")
target_fpaths_str = "\n- ".join(
[""] + [fp.replace("_conflict.json", ".json") for fp in conflicting_fpaths]
)
raise ValueError(f"""
Found conflicting aggregate metrics that need to be corrected:{conflicting_fpaths_str}

This could be due to a change in how metrics are calculated, leading to outdated metrics. Try deleting the below file(s) and rerunning data preparation:{target_fpaths_str}
""")

return dict(dataset_type_to_aggregate_metrics)

Expand Down Expand Up @@ -606,7 +613,14 @@ def collate_samples(

if conflicting_fpaths:
conflicting_fpaths_str = "\n- ".join([""] + conflicting_fpaths)
raise ValueError(f"Found conflicting aggregate metrics that need to be corrected:{conflicting_fpaths_str}")
target_fpaths_str = "\n- ".join(
[""] + [fp.replace("_conflict.json", ".json") for fp in conflicting_fpaths]
)
raise ValueError(f"""
Found conflicting aggregate metrics that need to be corrected:{conflicting_fpaths_str}

This could be due to a change in how metrics are calculated, leading to outdated metrics. Try deleting the below file(s) and rerunning data preparation:{target_fpaths_str}
""")

final_fpaths_str = "\n- ".join([""] + [f"{type}: {fpath}" for type, fpath in final_fpaths.items()])
print(f"View your final data!{final_fpaths_str}")
Expand Down