-
Notifications
You must be signed in to change notification settings - Fork 230
Add Huggingface support for data preparation #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 12 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9e12af8
Init hf flow for prepare data
fsiino-nvidia b18891e
Fix validation, error handling, and artifact_fpath for hf
fsiino-nvidia 8effa1f
Use hf identifier for datasets
fsiino-nvidia c74cb28
More dataset_url to huggingface_identifier replacements
fsiino-nvidia 4742cb8
Error messaging for missing hf artifact_fpath
fsiino-nvidia 53c090d
Convert to jsonl when artifact_fpath is None
fsiino-nvidia e5fbae3
Support non-jsonls, make hf default download source, fix tests
fsiino-nvidia ce02a42
Remove hf_token requirement for downloads
fsiino-nvidia 43ffe3b
Infer split, fix inheritance, update faq
fsiino-nvidia b1954ff
Remove dupe comment
fsiino-nvidia 7669d86
nit
fsiino-nvidia 0c9aa1c
Improve validation and messaging
fsiino-nvidia c8204a6
Remove dummy file
fsiino-nvidia e0fa317
Add datasets version, remove org and slug req
fsiino-nvidia 4b4e76d
Remove artifact_fpath for HF
fsiino-nvidia 2d71a32
Fix test
fsiino-nvidia e590818
Dual split and arg fixes for hf download and data prep
fsiino-nvidia e7f4478
Reinstate artifact_fpath for arbitrary jsonls, fix min swe dataset urls
fsiino-nvidia 84cbbd6
Merge remote-tracking branch 'github/main' into fsiino/416-hf-downloa…
fsiino-nvidia 3b8caf4
Update docs
fsiino-nvidia 51fb887
Update example metrics
fsiino-nvidia 64e6a78
Merge remote-tracking branch 'github/main' into fsiino/416-hf-downloa…
fsiino-nvidia 68adb7a
Merge remote-tracking branch 'github/main' into fsiino/416-hf-downloa…
fsiino-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,5 +70,4 @@ | |
| "Median": 299.0, | ||
| "Standard deviation": 0.0 | ||
| } | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fsiino-nvidia marked this conversation as resolved.
Outdated
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| { | ||
| "name": "train", | ||
| "type": "train", | ||
| "jsonl_fpath": "resources_servers/google_search/data/train.jsonl", | ||
| "num_repeats": 1, | ||
| "gitlab_identifier": { | ||
| "dataset_name": "search_STEM_syn_gpqa_v1_2_difficulty_filtered", | ||
| "version": "0.0.1", | ||
| "artifact_fpath": "MCQA_syn_gpqa_1_2_difficulty_filtered_responses_api.jsonl" | ||
| }, | ||
| "dataset_url": "https://huggingface.co/datasets/nvidia/Nemotron-RL-knowledge-web_search-mcqa", | ||
| "license": "Apache 2.0", | ||
| "Number of examples": 2907, | ||
| "Number of tools": { | ||
| "Total # non-null values": 2907, | ||
| "Average": 2.0, | ||
| "Min": 2.0, | ||
| "Max": 2.0, | ||
| "Median": 2.0, | ||
| "Standard deviation": 0.0 | ||
| }, | ||
| "Json-dumped number of words (proxy for token count)": { | ||
| "Total # non-null values": 2907, | ||
| "Average": 282.98, | ||
| "Min": 207.0, | ||
| "Max": 439.0, | ||
| "Median": 280.91, | ||
| "Standard deviation": 35.33 | ||
| }, | ||
| "Number of turns": { | ||
| "Total # non-null values": 2907, | ||
| "Average": 1.0, | ||
| "Min": 1.0, | ||
| "Max": 1.0, | ||
| "Median": 1.0, | ||
| "Standard deviation": 0.0 | ||
| }, | ||
| "Temperature": { | ||
| "Total # non-null values": 2907, | ||
| "Average": 0.6, | ||
| "Min": 0.6, | ||
| "Max": 0.6, | ||
| "Median": 0.6, | ||
| "Standard deviation": 0.0 | ||
| }, | ||
| "expected_answer": { | ||
| "unique_count": 4, | ||
| "total_count": 2907 | ||
| }, | ||
| "task_difficulty_qwen3_32b_avg_8": { | ||
| "Total # non-null values": 2907, | ||
| "Average": 0.374, | ||
| "Min": 0.25, | ||
| "Max": 0.5, | ||
| "Median": 0.374, | ||
| "Standard deviation": 0.103 | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.