fix(workplace-assistant): release session state after verification - #2886
Merged
ananthsub merged 1 commit intoAug 31, 2026
Merged
Conversation
Ensure per-rollout tool environments are removed even when scoring fails so the resources server does not retain unbounded session state. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
added
the
r0.6.0
init-nikhil
approved these changes
Aug 31, 2026
init-nikhil
left a comment
init-nikhil
left a comment
Member
There was a problem hiding this comment.
lgtm.
non-blocking: if the model call fails or times out before /verify is called, it looks like the tool environment created during seed session will still remain?
Contributor
Author
agreed. for that, we'd need a dedicated cleanup endpoint which is being proposed in #2612 |
ananthsub
added a commit
that referenced
this pull request
Aug 31, 2026
…on (2886)` into `r0.6.0` (#2902) beep boop [🤖]: Hi @ananthsub 👋, we've cherry picked #2886 into for you! 🚀 Please review and approve this cherry pick by your convenience! Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
This was referenced Sep 1, 2026
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
uv run gym env test --resources-server workplace_assistant(32 passed)pre-commit run --files resources_servers/workplace_assistant/app.py resources_servers/workplace_assistant/tests/test_app.py