fix(browsecomp): accept both vLLM /tokenize response shapes - #2789
Merged
Conversation
save_model_call_using_vllm_tokenize_endpoint reads len(response["tokens"]),
which only exists on older vLLM builds; mainstream >=0.19.1 returns
{"count": N, "max_model_len": ...} and omits the token list unless token
ids are requested, so the pre-call context-reset estimation dies with
KeyError: 'tokens' on every sample. Prefer the explicit count, fall back
to the token list, and fail loudly when neither is present.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: MJ Mikulski <mmikulski@nvidia.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: MJ Mikulski <mmikulski@nvidia.com>
Contributor
Author
|
/claude review |
Contributor
|
SHIP — LGTM, no reliability concerns. Focused robustness fix for |
marta-sd
reviewed
Aug 26, 2026
Contributor
Author
|
/ok to test 6c3a546 |
marta-sd
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_model_call_using_vllm_tokenize_endpointreadslen(response["tokens"]), which only exists on older vLLM builds; mainstream >=0.19.1 returns{"count": N, "max_model_len": ...}and omits the token list unless token ids are requested, so the pre-call context-reset estimation dies with KeyError: 'tokens' on every sample. Prefer the explicit count, fall back to the token list, and fail loudly when neither is present.What does this PR do?
Checklist
pre-commit run --all-files) (so CI lint/format/copyright pass).git commit -s) (so the DCO check passes).