refactor: decouple rollout identity from capture - #2783
Open
ananthsub wants to merge 7 commits into
Open
Conversation
Propagate rollout correlation through agents, model servers, and resources servers even when observability and training-token capture are disabled, so runtime features can rely on one stable identity. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Mint and persist UUIDv4 rollout IDs so correlation remains stable across retries and independent of task indexing. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
ansubramania/rollout-identity
branch
from
August 26, 2026 16:10
328f1e7 to
dbb568b
Compare
Contributor
Author
|
/ok to test dbb568b |
Update agent behavior and fixtures for mandatory UUID rollout IDs while keeping observability controlled by its explicit configuration. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
…t-identity Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> # Conflicts: # nemo_gym/rollout_collection.py # responses_api_agents/mini_swe_agent_2/tests/test_app.py
github-actions
Bot
added
the
sla:review-overdue
Keep Gym coordination metadata on every BaseRunRequest so strict UUID validation works across all agent implementations, and update affected fixtures to exercise UUID-prefixed model calls. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
…t-identity Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> # Conflicts: # responses_api_agents/swe_agents/app.py # responses_api_agents/swe_agents/tests/test_app.py
Contributor
Author
|
/ok to test 4b8e0db |
ananthsub
force-pushed
the
ansubramania/rollout-identity
branch
from
August 28, 2026 14:08
4b8e0db to
ecbd5a7
Compare
…t-identity Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
ansubramania/rollout-identity
branch
from
August 28, 2026 20:46
ecbd5a7 to
057f4bc
Compare
waple0820
added a commit
to waple0820/Gym
that referenced
this pull request
Sep 2, 2026
…rify NVIDIA-NeMo#2114 landed the rollout correlation contract, but it is one-directional. The training side learns nothing about the handle the environment actually allocated — the container, the browser context, the provider session that consumed quota — so a rollout record and a provider-side log can only be joined on a timestamp. `env_session_id` is optional on both `BaseSeedSessionResponse` and `BaseVerifyResponse`, opaque to Gym, and absent unless an environment reports one, so nothing changes for an environment that does not. This originally also added a `rollout_correlation_enabled` key so the rollout prefix could reach resources servers without turning on model-call capture. NVIDIA-NeMo#2783 removes that need by making correlation independent of the observability gate rather than adding a second flag, which is the better shape, so that half is dropped here. No training framework needs a transport change: verl and NeMo-RL already carry the whole verify response as `full_result`. Terminology: this is the environment session created by `/seed_session`, not the vLLM router KV-cache affinity of NVIDIA-NeMo#2570 / NVIDIA-NeMo#2347 / NVIDIA-NeMo#2369. Signed-off-by: waple0820 <232305951+waple0820@users.noreply.github.com>
|
This removes the need for half of #2613, which added a What's left there is the other direction: |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This provides a stable runtime identity for features such as #2141 without requiring model-call observability.
Test plan
uv run pytest tests/unit_tests/test_base_responses_api_agent.py tests/unit_tests/test_base_responses_api_model.py tests/unit_tests/test_server_utils.py tests/unit_tests/test_rollout_collection.py -q(201 passed)uv run pre-commit run --all-files