Skip to content

fix: flaky fireworks-e2e test #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kajalj22 merged 7 commits into from
Aug 25, 2026
Merged

fix: flaky fireworks-e2e test #2753

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ede63c8
fix: pin temperature to 0 in fireworks-e2e inference provider test
kajalj22 Aug 25, 2026
ce56b16
ci: upload provider e2e results as artifacts for debugging
kajalj22 Aug 25, 2026
a5691df
Merge branch 'main' into fix-flaky-fireworks-e2e-temperature
kajalj22 Aug 25, 2026
b725ba1
fix: use a dedicated unambiguous prompt for fireworks-e2e
kajalj22 Aug 25, 2026
5ad0411
test: update golden-string assertion for smoke dataset path
kajalj22 Aug 25, 2026
5512587
fix: drop tool_choice=required from the smoke prompt
kajalj22 Aug 25, 2026
f360125
Merge branch 'main' into fix-flaky-fireworks-e2e-temperature
kajalj22 Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/cicd-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,15 @@ jobs:
MODEL_API_KEY: ${{ secrets[matrix.model_api_key_secret_name] }}
run: bash tests/e2e/run_inference_provider_e2e.sh

- name: Upload provider E2E artifacts
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: ${{ matrix.provider }}-e2e-results-${{ github.run_id }}-${{ github.run_attempt }}
path: ${{ runner.temp }}/nemo-gym-${{ matrix.provider }}-e2e/results
if-no-files-found: warn
retention-days: 7

Nemo_CICD_Test:
needs: [pre-flight, classify_changes, unit_tests, container_build, gpu_e2e_tests, provider_e2e_tests]
if: always() && !cancelled()
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/run_inference_provider_e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ GYM_PID=$!
--input "$ROOT_DIR/resources_servers/example_single_tool_call/data/example.jsonl" \
--output "$RESULTS_DIR/rollouts.jsonl" \
--limit 1 \
--temperature 0 \
--max-output-tokens 4096

"$VENV_DIR/bin/python" "$ROOT_DIR/tests/e2e/verify_inference_provider_rollout.py" \
Expand Down
Loading