fix: preserve HTTP errors across process boundaries - #2726
Conversation
888126d to
48ea269
Compare
|
/ok to test 48ea269 |
4f861a2 to
15a9d6a
Compare
|
/ok to test 15a9d6a |
|
The current head is green across unit tests, all server shards, the container build, and the Qwen GPU E2E. The only red check is |
init-nikhil
left a comment
There was a problem hiding this comment.
other than the header information loss issue, looks good 👍
15a9d6a to
8884c85
Compare
|
/ok to test 8884c85 |
8884c85 to
179d8e0
Compare
|
/ok to test 179d8e0 |
Replace aiohttp's unpicklable response metadata with pickle-safe values while preserving the status, message, URL, case-insensitive multi-value headers, and response body. Based on the exception-handling fix proposed by Yuchen Wang in NVIDIA-NeMo#1788. Co-authored-by: Yuchen Wang <yuchenwang3@users.noreply.github.com> Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
179d8e0 to
1e67fc4
Compare
|
/claude review |
|
/ok to test 1e67fc4 |
|
SHIP — targeted fix, no reliability concerns.
The fix replaces the unpicklable members with pickle-safe equivalents (
One minor note (author's call, non-blocking): the |
Summary
aiohttp.ClientResponseErrorproxy metadata with pickle-safe values before propagationThis extracts and hardens the exception-handling fix proposed by @yuchenwang3 in #1788. The original PR also changes rollout retries; this PR intentionally contains only the serialization fix.
Co-authored-by: Yuchen Wang yuchenwang3@users.noreply.github.com
Test plan
uv run --extra dev pre-commit run --files nemo_gym/server_utils.py tests/unit_tests/test_server_utils.pyuv run --extra dev pytest tests/unit_tests/test_server_utils.py -q