fix(docs): remove absolute internal URL from 0.5.0 release notes - #2397
Merged
Conversation
Fixes test_internal_pages_are_linked_by_path_not_by_absolute_url. The docs.nvidia.com/nemo/gym link in the sandboxing section must use a relative path; removed the sentence referencing the providers page. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kajal Jain <kajalj@nvidia.com>
…ase notes Replace absolute docs.nvidia.com URL with a relative path so readers stay within the version they are reading, as required by test_internal_pages_are_linked_by_path_not_by_absolute_url. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kajal Jain <kajalj@nvidia.com>
kajalj22
added
the
r0.5.0
ananthsub
approved these changes
Aug 6, 2026
Contributor
|
🌿 Preview your docs: https://nvidia-preview-fix-release-notes-absolute-url.docs.buildwithfern.com/nemo/gym Here are the markdown pages you've updated: |
kajalj22
added a commit
that referenced
this pull request
Aug 7, 2026
… (2397)` into `r0.5.0` (#2398) beep boop [🤖]: Hi @kajalj22 👋, we've cherry picked #2397 into for you! 🚀 Please review and approve this cherry pick by your convenience! Signed-off-by: Kajal Jain <kajalj@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: kajalj22 <kajalj@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
…DIA-NeMo#2397) ## Summary Fixes the `test_internal_pages_are_linked_by_path_not_by_absolute_url` test failure introduced by NVIDIA-NeMo#2389. The v0.5.0 release notes sandboxing section contained a `docs.nvidia.com/nemo/gym/...` absolute link. The test requires all internal docs links in `latest/` to use relative paths (to keep readers within the version they're reading). Replaced with a relative path `/nemo-gym/nemo_gym/sandbox/providers` in both `latest/` and the `v0.5.0/` snapshot. ## Test plan - [ ] `test_internal_pages_are_linked_by_path_not_by_absolute_url` passes - [ ] Cherry-pick to `r0.5.0` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: Kajal Jain <kajalj@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
test_internal_pages_are_linked_by_path_not_by_absolute_urltest failure introduced by #2389.The v0.5.0 release notes sandboxing section contained a
docs.nvidia.com/nemo/gym/...absolute link. The test requires all internal docs links inlatest/to use relative paths (to keep readers within the version they're reading). Replaced with a relative path/nemo-gym/nemo_gym/sandbox/providersin bothlatest/and thev0.5.0/snapshot.Test plan
test_internal_pages_are_linked_by_path_not_by_absolute_urlpassesr0.5.0🤖 Generated with Claude Code