cp: fix(tau2): exclude review_model from snapshot comparison into r0.5.0 - #2337
Merged
Conversation
\`test_sanity_query_input\` was failing in CI because \`review_model\`
is present in \`test_data.json\` (the snapshot) but absent from the
actual server response in some tau2-bench versions.
\`review_model\` was added to \`TextRunConfig\` in tau2-bench v1.0.1
with a default of \`'claude-opus-4-5'\`. Its presence in the serialized
config depends on which tau2-bench commit is installed. The test's
\`_clean()\` function already strips other volatile config fields
(\`max_agent_steps\`, \`turns_remaining_interval\`) — adding
\`review_model\` follows the same pattern and makes the comparison
stable across tau2-bench versions.
One line added to \`_clean()\` in
\`responses_api_agents/tau2/tests/test_app.py\`:
\`\`\`python
d["config"].pop("review_model", None)
\`\`\`
6/6 tau2 tests pass locally.
Failure first surfaced in the full suite run off #2290:
https://github.com/NVIDIA-NeMo/Gym/actions/runs/30840804435
Signed-off-by: Kajal Jain <kajalj@nvidia.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Christian Munley <cmunley@nvidia.com>
Contributor
Author
|
/ok to test 061b160 |
kajalj22
enabled auto-merge (squash)
August 5, 2026 01:54
kajalj22
disabled auto-merge
August 5, 2026 01:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of a8626cb into r0.5.0.
d["config"].pop("review_model", None)to_clean()intest_sanity_query_inputreview_modelis present intest_data.jsonbut absent from the actual server response at tau2-bench v1.0.1, causing the assertion to failsecurity: bump mlflow to 3.15.1 (2298)intor0.5.0#2320 (mlflow bump to r0.5.0) which fails CI due to this missing fix🤖 Generated with Claude Code