refactor(remote_agent): single-pass unpaired-call guard - #2321
Merged
Conversation
Replace the two comprehensions with one pass over the output items, per review suggestion on #2163. Behavior change pinned by a new test: duplicate call_ids now collapse to the last occurrence instead of executing each (call_id is unique by contract). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: adil-a <adil.asif2000@hotmail.com>
adil-a
added
the
r0.5.0
ffrujeri
approved these changes
Aug 4, 2026
ananthsub
pushed a commit
that referenced
this pull request
Aug 6, 2026
…into `r0.5.0` (#2322) beep boop [🤖]: Hi @adil-a 👋, we've cherry picked #2321 into for you! 🚀 Please review and approve this cherry pick by your convenience! Signed-off-by: adil-a <adil.asif2000@hotmail.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: Adil <47084919+adil-a@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: kajalj22 <kajalj@nvidia.com>
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
…2321) Follow-up to NVIDIA-NeMo#2163, the unpaired call guard now makes one pass over the output items instead of two comprehensions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: adil-a <adil.asif2000@hotmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2163, the unpaired call guard now makes one pass over the output items instead of two comprehensions.
🤖 Generated with Claude Code