docs: correct Workplace Assistant tool and database counts - #2314
Merged
ananthsub merged 1 commit intoAug 5, 2026
Conversation
Contributor
|
🌿 Preview your docs: https://nvidia-preview-ananthsub-docs-workplace-counts.docs.buildwithfern.com/nemo/gym Here are the markdown pages you've updated: |
ananthsub
marked this pull request as ready for review
August 4, 2026 15:12
ananthsub
added
the
r0.5.0
ananthsub
marked this pull request as draft
August 4, 2026 15:19
ananthsub
marked this pull request as ready for review
August 4, 2026 15:26
github-actions
Bot
added
the
sla:review-overdue
ananthsub
force-pushed
the
ananthsub/docs-workplace-counts
branch
from
August 5, 2026 21:48
4a94773 to
fa89282
Compare
ananthsub
enabled auto-merge (squash)
August 5, 2026 21:48
adil-a
approved these changes
Aug 5, 2026
The Workplace Assistant docs quoted four different figures for the same environment. `get_tools` in resources_servers/workplace_assistant/utils.py is the source of truth: it always registers the company directory lookup, then adds one toolkit per requested name. With the five toolkits app.py seeds each session with, that is 27 tools across five mutable databases plus the company directory. Corrected: - evaluation/environment-list.mdx: 26 tools -> 27 tools - generating-training-data.mdx: "27 tools across 6 databases" -> five databases plus a company directory lookup - about-workplace-assistant.mdx: the 27 tools are the five databases plus the company directory, not 27 tools across five databases - both workplace_assistant READMEs: 26 tools -> 27 tools mcp-resources-server.mdx already matched the code and is unchanged. Adds resources_servers/workplace_assistant/tests/test_docs_counts.py, which derives the count from get_tools and asserts every page and README that quotes it. Adding or removing a tool now fails a test instead of making the docs stale. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
ananthsub/docs-workplace-counts
branch
from
August 5, 2026 22:17
fa89282 to
1bd140a
Compare
ananthsub
added a commit
that referenced
this pull request
Aug 5, 2026
…)` into `r0.5.0` (#2371) beep boop [🤖]: Hi @ananthsub 👋, we've cherry picked #2314 into for you! 🚀 Please review and approve this cherry pick by your convenience! Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
…Mo#2314) The Workplace Assistant docs quote four different figures for the same environment: 26 tools / 5 databases, 27 tools / 5 databases, 27 tools / 6 databases, and 27 tools split as five toolkits plus a company directory. `get_tools` in `resources_servers/workplace_assistant/utils.py` is the source of truth. It always registers the company directory lookup, then adds one toolkit per requested name. Running it with the five toolkits `app.py` seeds each session with: ``` functions: 27 schemas: 27 containers: analytics, calendar, company_directory, customer_relationship_manager, email, project_management per-toolkit: email 6, analytics 6, calendar 5, project_management 5, crm 4, company_directory 1 ``` So: 27 tools across five mutable databases plus a read-only company directory. `is_correct` (utils.py:166) compares final state for the five databases and not the company directory, which only exposes `find_email_address`. ## Changes - `evaluation/environment-list.mdx`: 26 tools to 27 tools - `generating-training-data.mdx`: "27 tools across 6 databases" to five databases plus a company directory lookup - `about-workplace-assistant.mdx`: the 27 tools are the five databases plus the company directory, not 27 tools spread across five databases - `environments/workplace_assistant/README.md` and `resources_servers/workplace_assistant/README.md`: 26 tools to 27 tools `mcp-resources-server.mdx` already matched the code and is unchanged. ## Test `resources_servers/workplace_assistant/tests/test_docs_counts.py` derives the count from `get_tools` and asserts every page and README that quotes it. Adding or removing a tool now fails a test instead of leaving the docs stale. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Workplace Assistant docs quote four different figures for the same environment: 26 tools / 5 databases, 27 tools / 5 databases, 27 tools / 6 databases, and 27 tools split as five toolkits plus a company directory.
get_toolsinresources_servers/workplace_assistant/utils.pyis the source of truth. It always registers the company directory lookup, then adds one toolkit per requested name. Running it with the five toolkitsapp.pyseeds each session with:So: 27 tools across five mutable databases plus a read-only company directory.
is_correct(utils.py:166) compares final state for the five databases and not the company directory, which only exposesfind_email_address.Changes
evaluation/environment-list.mdx: 26 tools to 27 toolsgenerating-training-data.mdx: "27 tools across 6 databases" to five databases plus a company directory lookupabout-workplace-assistant.mdx: the 27 tools are the five databases plus the company directory, not 27 tools spread across five databasesenvironments/workplace_assistant/README.mdandresources_servers/workplace_assistant/README.md: 26 tools to 27 toolsmcp-resources-server.mdxalready matched the code and is unchanged.Test
resources_servers/workplace_assistant/tests/test_docs_counts.pyderives the count fromget_toolsand asserts every page and README that quotes it. Adding or removing a tool now fails a test instead of leaving the docs stale.