fix(cli): report cleanly unresolved config interpolations; fix the env resolve docs example - #2310
Merged
Merged
Conversation
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
Contributor
|
🌿 Preview your docs: https://nvidia-preview-edobrowolska-config-error-handling.docs.buildwithfern.com/nemo/gym Here are the markdown pages you've updated: |
kajalj22
added
the
r0.5.0
init-nikhil
approved these changes
Aug 4, 2026
kajalj22
added a commit
that referenced
this pull request
Aug 5, 2026
…he env resolve docs example (2310)` into `r0.5.0` (#2336) beep boop [🤖]: Hi @e-dobrowolska 👋, we've cherry picked #2310 into for you! 🚀 Please review and approve this cherry pick by your convenience! Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: Ewa Dobrowolska <117774842+e-dobrowolska@users.noreply.github.com> Co-authored-by: kajalj22 <kajalj@nvidia.com>
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
…v resolve docs example (NVIDIA-NeMo#2310) Fix defects E and G. `gym env validate` promised "a clean message, no traceback" but dumped omegaconf's stack trace when an interpolation couldn't be resolved; adds `ConfigInterpolationError` and translates the omegaconf exception at the parsing boundary. Also fixes the `gym env resolve` docs example, which needed three `++policy_*` keys it never mentioned - unlike `validate`, `resolve` substitutes no dummy model. --------- Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix defects E and G.
gym env validatepromised "a clean message, no traceback" but dumped omegaconf's stack trace when an interpolation couldn't be resolved; addsConfigInterpolationErrorand translates the omegaconf exception at the parsing boundary. Also fixes thegym env resolvedocs example, which needed three++policy_*keys it never mentioned - unlikevalidate,resolvesubstitutes no dummy model.