fix(cli): uniform name key, model usage examples, and parseable --json output - #2305
Merged
Conversation
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
kajalj22
added
the
r0.5.0
adil-a
reviewed
Aug 4, 2026
| rows = [{"model": entry.name, "model_group": entry.model_group} for entry in models.values()] | ||
| # One row per passable `--model-type` value: `model` is the token, `model_group` its model. `name` carries | ||
| # the same value as `model` so every component type keys its rows on `name` (`model` kept for compatibility). | ||
| rows = [{"name": entry.name, "model": entry.name, "model_group": entry.model_group} for entry in models.values()] |
Contributor
There was a problem hiding this comment.
who is keying into rows with name?
Contributor
Author
There was a problem hiding this comment.
not sure who is keying, but this was directly requested by QA: "Defect D — list models --json omits the name key (PRODUCT BUG)".
They left a suggested fix: "Add name to the models projection (keeping model/model_group as aliases for one release), then deprecate."
Alternatively, we can drop this and leave a textual response to QA instead
adil-a
previously approved these changes
Aug 5, 2026
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
adil-a
approved these changes
Aug 5, 2026
e-dobrowolska
added a commit
that referenced
this pull request
Aug 5, 2026
…--json output (2305)` into `r0.5.0` (#2360) beep boop [🤖]: Hi @e-dobrowolska 👋, we've cherry picked #2305 into for you! 🚀 Please review and approve this cherry pick by your convenience! Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: Ewa Dobrowolska <117774842+e-dobrowolska@users.noreply.github.com> Co-authored-by: kajalj22 <kajalj@nvidia.com>
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
…n output (NVIDIA-NeMo#2305) Three small fixes (defects D, F, H): `gym list models --json` now includes a `name` key like every other component type (`model` kept, so `jq '.[].model'`still works); model inspection shows a usage example like benchmarks and environment already did, and `gym env packages` only prints its header in the default view so `--json` pipes cleanly. Agents still show no usage example - their names aren't valid `--agent` values, so there's nothing runnable to suggest until NVIDIA-NeMo#1583 lands a real agent selector. --------- Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com> Co-authored-by: kajalj22 <kajalj@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes (defects D, F, H):
gym list models --jsonnow includes anamekey like every other component type (modelkept, sojq '.[].model'still works); model inspection shows a usage example like benchmarks and environment already did, andgym env packagesonly prints its header in the default view so--jsonpipes cleanly.Agents still show no usage example - their names aren't valid
--agentvalues, so there's nothing runnable to suggest until #1583 lands a real agent selector.