Skip to content

feat: option to skip verification - #2279

Merged
bxyu-nvidia merged 6 commits into
mainfrom
amahishi/option-skip-verification-v2
Aug 19, 2026
Merged

feat: option to skip verification#2279
bxyu-nvidia merged 6 commits into
mainfrom
amahishi/option-skip-verification-v2

Conversation

@macandro96

Copy link
Copy Markdown
Contributor

Summary

Adds a response API agent option to skip resources-server verification during /run.

When skip_verification=true, agents return a synthetic verify response using skip_verification_reward and mark it with verification_skipped=true. Top-level config values are propagated to response API agents unless the agent explicitly sets its own values.

Changes

  • Add skip_verification and skip_verification_reward to base response API agent config.
  • Add skipped-verification response payload helper.
  • Wire skip behavior into simple_agent and tool_simulation_agent.
  • Add global config propagation for top-level skip-verification defaults.
  • Add tests for config defaults, payload construction, and agent /run behavior.

Cherry pick from here

HeyyyyyyG and others added 2 commits July 31, 2026 13:31
Signed-off-by: Jiaqi Zeng <jiaqiz@nvidia.com>
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the sla:triage-overdue Review assignment is over the one-business-day SLA label Aug 3, 2026
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Comment thread nemo_gym/base_responses_api_agent.py Outdated
"verification_skipped": True,
}

async def call_verify_or_skip(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the intent of this call_verify_or_skip util, but imo it is more intuitive to have smth super obvious in the /run code like:

        verify_request = SimpleAgentVerifyRequest.model_validate(body.model_dump() | {"response": model_response_json})

        if self.config.skip_verification:
            verify_response = await self.server_client.post(
                server_name=self.config.resources_server.name,
                url_path="/verify",
                json=verify_request.model_dump(),
                cookies=cookies,
            )
            await raise_for_status(verify_response)
            result = await get_response_json(verify_response)
        else:
            result = body.model_dump() | {
                "response": response_payload,
                "reward": 0,
                "verification_skipped": True,
            }

that way when our users build similar things everything they need is right in front of them, especially if they need to customize

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addressed in 629c433

@github-actions github-actions Bot removed the sla:triage-overdue Review assignment is over the one-business-day SLA label Aug 5, 2026
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
@macandro96
macandro96 requested a review from bxyu-nvidia August 6, 2026 00:47
@github-actions github-actions Bot added the sla:review-overdue Review response is over the one-business-day SLA label Aug 7, 2026
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
@bxyu-nvidia
bxyu-nvidia merged commit 2251ef7 into main Aug 19, 2026
25 of 27 checks passed
@bxyu-nvidia
bxyu-nvidia deleted the amahishi/option-skip-verification-v2 branch August 19, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sla:review-overdue Review response is over the one-business-day SLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants