Skip to content

docs: source: union, clean config errors, and new discovery/validate CLI commands - #1754

Merged
wprazuch merged 8 commits into
mainfrom
wprazuch/docs-cli-config
Jun 29, 2026
Merged

docs: source: union, clean config errors, and new discovery/validate CLI commands#1754
wprazuch merged 8 commits into
mainfrom
wprazuch/docs-cli-config

Conversation

@wprazuch

@wprazuch wprazuch commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Documents the config/CLI features merged for epic #1205 that were not yet reflected in the docs. Requested follow-up: a single doc PR covering the recently merged config/CLI work.

What's documented

Area Change Merged in
reference/cli-commands.mdx New gym list environments, gym list agents, and gym env validate sections (+ Quick-Reference entries) #1635, #1671, #1599
troubleshooting/configuration.mdx Three config_paths startup errors (Config Path Not Found, Malformed config_paths, No Server Instances) + a gym env validate pre-flight tip; corrected the stale ServerRefNotFound message #1609, #1599
data/index.mdx Unified dataset source: block + dedicated "Dataset source" subsection + legacy-deprecation note #1637
data/download-huggingface.mdx Auto-download example migrated to source: { type: huggingface } #1637
reference/faq.mdx Dataset example and field bullets rewritten around source: #1637
environment-tutorials/single-step-environment.mdx Scaffold comment updated to reference source: #1637

@copy-pr-bot

copy-pr-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@sephmard
sephmard self-requested a review June 26, 2026 16:59
@sephmard sephmard added the documentation Improvements to documentation label Jun 26, 2026
wprazuch added 7 commits June 29, 2026 09:31
Document the config/CLI features merged for epic #1205:
- gym list environments / gym list agents / gym env validate
- config_paths startup errors + validate pre-flight tip
- the unified dataset `source:` block (replaces gitlab_identifier/huggingface_identifier)

Refs #1737

Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
… example

Review fixes for the doc PR:
- Remove the `python -m nemo_gym.dataset_source_migration` reference (that
  module ships in a still-open PR, not on main)
- Migrate the second faq.mdx dataset example to `source:` (it still used the
  legacy identifiers, contradicting the surrounding prose)
- Add a `source` row to the canonical dataset field table in
  reference/configuration.mdx
- Complete the `gym env validate` flag table (resources-server, model-type,
  model/url/api-key)
- Fix ServerRefNotFound prose to match the "Available <type>" message
- "HuggingFace" -> "Hugging Face"; <Tip> trailing blank line

Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
…ot 'Available'

The hint is either/or: get_close_matches (difflib, cutoff 0.6) returns a
suggestion for a typo like typo_weather->weather, so the example fires the
'Did you mean:' branch. The 'Available <type>:' form only shows when no close
match exists. Restore the correct example and describe both branches.

Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
… reference

The Domain enum (config_types.py:516) has 12 values; the docs listed only 10,
omitting 'translation' and 'rlhf' (the latter is in active use, e.g. the
abstention env). Update the Almost-Servers sample pydantic error and the
canonical Domain values list in the configuration reference.

Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
@wprazuch
wprazuch force-pushed the wprazuch/docs-cli-config branch from c73f244 to 376be73 Compare June 29, 2026 07:31
gym env validate # validate a config (no Ray, no servers) — fast pre-flight check
gym env packages # list packages in a server's virtual environment
gym env test # test resources server(s); all of them if none is given
gym env start # start the servers

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually on me, but could you please fix the space between comment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 44d5517

nemo_gym.config_types.ConfigPathNotFoundError: config_paths entry 'resources_servers/weather/config.yaml' was not found. Looked in:
- /path/to/cwd/resources_servers/weather/config.yaml
- /path/to/gym/resources_servers/weather/config.yaml
Check the path is spelled correctly and is relative to your working directory or the Gym install root.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute path should work too (at least that was my intention)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed in 44d5517

…paths work

- Fix comment alignment on the 'gym env start' quick-reference line (marta-sd)
- Clarify in the Config Path Not Found fix that an absolute config_paths entry
  works too, not only repo-root-relative ones (verified: global_config.py only
  prefixes cwd/install root when the path is not absolute) (marta-sd)

Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
@wprazuch
wprazuch merged commit fece4fe into main Jun 29, 2026
10 checks passed
@wprazuch
wprazuch deleted the wprazuch/docs-cli-config branch June 29, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants