Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_gym/cli/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ def init_resources_server(): # pragma: no cover
jsonl_fpath: resources_servers/{server_type_name}/data/train.jsonl # local data file for this split
num_repeats: 1 # times to repeat each example (e.g. for pass@k / mean@k)
license: Apache 2.0 # required for train/validation; must be an allowed license string
# to fetch this split from a registry instead, add gitlab_identifier: or huggingface_identifier:
# to fetch this split from a registry instead, add a source: block (type: gitlab | huggingface)
- name: validation
type: validation
jsonl_fpath: resources_servers/{server_type_name}/data/validation.jsonl
Expand Down
6 changes: 6 additions & 0 deletions tests/unit_tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,12 @@ def test_init_resources_server_includes_domain(self) -> None:
# This should not raise an assertion error about missing domain
instance_config = ResourcesServerInstanceConfig.model_validate(full_config_dict)
assert instance_config is not None

# The generated config points users at the unified `source:` identifier, not the
# deprecated gitlab_identifier/huggingface_identifier.
assert "source:" in config_text
assert "gitlab_identifier" not in config_text
assert "huggingface_identifier" not in config_text
finally:
# Clean up the test server directory
if server_path.exists():
Expand Down
Loading