feat: expose terminal failure locations - #861
Draft
andreatnvidia wants to merge 1 commit into
Draft
Conversation
Add opt-in terminal failure capture for create and preview results, including zero-row generation errors. Surface early shutdown so callers can distinguish cancelled rows from attributable terminal failures. Closes #860 Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Contributor
|
Fern preview: https://nvidia-preview-pr-861.docs.buildwithfern.com/nemo/datadesigner
|
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Add an opt-in, lightweight terminal-failure locator for callers that need to reconcile omitted rows without enabling full task tracing. This supports merged Anonymizer pipelines while leaving the default generation path unchanged.
🔗 Related Issue
Closes #860
🔄 Changes
capture_terminal_failurestocreate(),acreate(), andpreview().(seed_row_index, column)terminal failures on successful results and zero-row generation errors.early_shutdownon successful results so callers can detect when cancelled rows have no truthful column attribution.🔍 Attention Areas
seed_row_indexis the requested generation-sequence position. It maps directly to the raw seed row only for compatible ordered seeding.terminal_failuresexcludes rows cancelled by global early shutdown. Callers should checkearly_shutdownbefore treating the list as complete.🧪 Testing
✅ Checklist